Summary: | [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | Tools / Tests | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2012-06-18 10:56:51 PDT
I'm not quite following how to see the actual bug in the garden-o-matic UI. Created attachment 148130 [details]
Patch
Comment on attachment 148130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148130&action=review > Tools/ChangeLog:12 > + (.): Remove this. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:370 > + var builderHash = builderName.replace(/[ .()]/g, '_'); This looks very similar to config.resultsDirectoryNameFromBuilderName() for chromium. Maybe put a function in base and call it in both places. (In reply to comment #3) > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:370 > > + var builderHash = builderName.replace(/[ .()]/g, '_'); > > This looks very similar to config.resultsDirectoryNameFromBuilderName() for chromium. Maybe put a function in base and call it in both places. Created base.underscoredBuilderName. Committed http://trac.webkit.org/changeset/120614. |