Bug 89332

Summary:

REGRESSION(r120546): It made 3 webkitpy tests fail

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cdumez, dpranke, ojan, simon.fraser, webkit.review.bot, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84642

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue+

Csaba Osztrogonác

Reported 2012-06-17 23:56:50 PDT

It broke 3 webkitpy tests. Could you check it, please? ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_complex_shadowing -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 169, in test_complex_shadowing 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036' File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/mac': '5daa78e55f05d9f0d1bb1f32b0cd1bc3a01e9364', 'LayoutTests/platform/win-xp': '5b1253ef4d5094530d5f1bc6cdb95c90b446bec7', 'LayoutTests/platform/chromium-win-xp': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/chromium-mac-leopard': '65e7d42f8b4882b29d46dc77bb879dd41bc074dc', 'LayoutTests/platform/chromium-win-vista': 'f83af9732ce74f702b8c9c4a3d9a4c6636b8d3bd', 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036'} != {'LayoutTests/platform/mac-leopard': '7ad045ece7c030e2283c5d21d9587be22bcba56e', 'LayoutTests/platform/chromium-win-vista': 'f83af9732ce74f702b8c9c4a3d9a4c6636b8d3bd', 'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/mac': '5daa78e55f05d9f0d1bb1f32b0cd1bc3a01e9364', 'LayoutTests/platform/win': '5b1253ef4d5094530d5f1bc6cdb95c90b446bec7', 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036', 'LayoutTests/platform/chromium-win-xp': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/chromium-mac-leopard': '65e7d42f8b4882b29d46dc77bb879dd41bc074dc'} ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_mac_future -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 112, in test_mac_future 'LayoutTests/platform/mac-snowleopard': '462d03b9c025db1b0392d7453310dbee5f9a9e74', File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {} != {'LayoutTests/platform/mac-snowleopard': '462d03b9c025db1b0392d7453310dbee5f9a9e74'} ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_no_add_mac_future -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 88, in test_no_add_mac_future 'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554', File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {'LayoutTests/platform/win-xp': '453e67177a75b2e79905154ece0efba6e5bfb65d', 'LayoutTests/platform/mac': '29a1715a6470d5dd9486a142f609708de84cdac8', 'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554'} != {'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554', 'LayoutTests/platform/mac': '29a1715a6470d5dd9486a142f609708de84cdac8', 'LayoutTests/platform/win': '453e67177a75b2e79905154ece0efba6e5bfb65d', 'LayoutTests/platform/mac-snowleopard': 'c43eaeb358f49d5e835236ae23b7e49d7f2b089f'}

Attachments
Patch (4.72 KB, patch) 2012-06-18 11:22 PDT, Zan Dobersek	abarth: review+ abarth: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2012-06-18 11:03:44 PDT

These tests stated failing because I removed old Mac builders from webkitpy/layout_tests/port/builders.py. I'm not sure what the right solution is.

Zan Dobersek

Comment 2 2012-06-18 11:22:27 PDT

Created attachment 148133 [details] Patch

Dirk Pranke

Comment 3 2012-06-18 13:07:08 PDT

Committed r120620: <http://trac.webkit.org/changeset/120620>

Note You need to log in before you can comment on or make changes to this bug.