Bug 89331 – [chromium] Spellchecker should show suggestions only when right-clicking a misspelled word.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Hironori Bono]

Greetings,

Step to reproduce:
1. Type "This is a lasy doga." in a text area.
2. Type ctrl+A to select all text in the text area.
3. Right-click a mouse.

Expected Behavior:
* Chromium should not show suggestions.

Actual Behavior:
* Chromium shows two suggestions: "last" and "dog".

Unfortunately, my r118740 <http://trac.webkit.org/changeset/118740> has a bug that Chrome may show suggestion for all misspelled words in the selection if it is not collapsed. Also, my r120274 <http://trac.webkit.org/changeset/120274> has a bonehead mistake that used a wrong range to replace text.

Regards,

Hironori Bono

[Hironori Bono]

Created attachment 148065 [details]
Patch v1

Greetings Morita-san,

Would it be possible to review this quick fix?

Regards,

Hironori Bono

[Hajime Morrita]

Comment on attachment 148065 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=148065&action=review

The code looks good.

> Source/WebKit/chromium/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=89331

Could you give a bit more detailed explanation?
Seeing only this change doesn't give any rationale behind the change.

[Hironori Bono]

Created attachment 148070 [details]
Patch v1 (updated ChangeLog)

Greetings Morita-san,

Many thanks for your quick review.
I have updated ChangeLog to describe the background.

Regards,

Hironori Bono

[WebKit Review Bot]

Comment on attachment 148070 [details]
Patch v1 (updated ChangeLog)

Rejecting attachment 148070 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 148070 [details]
Patch v1 (updated ChangeLog)

Clearing flags on attachment: 148070

Committed r120586: <http://trac.webkit.org/changeset/120586>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Hironori Bono]

Greetings,

Sorry, I noticed this was not a good fix. (It is better for us to emulate Firefox.) Would it be possible to roll out my r120586?

Regards,

Hironori Bono

[WebKit Review Bot]

Re-opened since this is blocked by 89444

[Hironori Bono]

Created attachment 148305 [details]
Patch v2 (fixed a regression on Mac)

Greetings Morita-san,

Thanks for your help and apologies for my previous change. I have re-implemented my change to emulate the behavior of Mac Chrome so we do not need workarounds for Mac. Would it be possible to review this change?

Regards,

Hironori Bono

[WebKit Review Bot]

Comment on attachment 148305 [details]
Patch v2 (fixed a regression on Mac)

Clearing flags on attachment: 148305

Committed r120810: <http://trac.webkit.org/changeset/120810>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Yair Yogev]

This fix is the cause of a very weird regression in Windows (only tested windows):
let's say i'm posting a comment IGNORETHISWORD in WebKit Bugzilla, just like i am right now .
All my words are spelled correctly except for one, that capital letters gibberish in the second line.

Now i would like to copy my comment before submitting, so i: 
1. Press Ctrl+A
2. right click the selection (anywhere)

The selection will now change: The part of the text before the gibberish word will be deselected and if the last text block is longer than the horizontal position of the gibberish word, then any text in that block after that position will also be deselected.

[Yair Yogev]

screenshot of comment #12 http://i47.tinypic.com/2myrzpf.jpg

[Yair Yogev]

Was this change suppose to actually change the selection? i don't think it should...

[Yair Yogev]

For one lined text field, with one misspelled word, it deselects the whole selection except for the misspelled word, although i didn't right click the misspelled word and all i wanted to do is Copy the text using the context menu option...

I hope that's not intentional, the spell checker shouldn't interfere with basic text handling capabilities.