Bug 89330

Summary: Fix syntax of FileReader::readAsDataURL result
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: New BugsAssignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli, kinuko, levin, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Taiju Tsuiki 2012-06-17 23:45:30 PDT 
According to RFC2397, syntax of Data URL is like that:
> dataurl    := "data:" [ mediatype ] [ ";base64" ] "," data
http://tools.ietf.org/html/rfc2397

That is, ";" before "base64" is required.
However, current implementation of readAsDataURL returns Data URL without ";", when media type is not specified.
Comment 1 Taiju Tsuiki 2012-06-17 23:57:59 PDT 
Created attachment 148062 [details]
Patch
Comment 2 Taiju Tsuiki 2012-06-18 00:10:00 PDT 
Comment on attachment 148062 [details]
Patch

Needs some more rebaseline
Comment 3 Taiju Tsuiki 2012-06-18 00:12:40 PDT 
Created attachment 148067 [details]
Patch
Comment 4 Kinuko Yasuda 2012-06-18 02:00:00 PDT 
Comment on attachment 148067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148067&action=review

The change looks good to me.

> Source/WebCore/ChangeLog:7
> +

Nit: can you add when it gets broken? (e.g. "when media type is not specified")

Please list affected tests as well (Test: ....).
Comment 5 Taiju Tsuiki 2012-06-18 02:36:06 PDT 
Created attachment 148075 [details]
Patch
Comment 6 Taiju Tsuiki 2012-06-18 02:39:40 PDT 
Comment on attachment 148067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148067&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Nit: can you add when it gets broken? (e.g. "when media type is not specified")
> 
> Please list affected tests as well (Test: ....).

Done
Comment 7 Kent Tamura 2012-06-18 02:45:53 PDT 
Comment on attachment 148075 [details]
Patch

Looks ok.
Comment 8 WebKit Review Bot 2012-06-18 03:30:58 PDT 
Comment on attachment 148075 [details]
Patch

Clearing flags on attachment: 148075

Committed r120583: <http://trac.webkit.org/changeset/120583>
Comment 9 WebKit Review Bot 2012-06-18 03:31:03 PDT 
All reviewed patches have been landed.  Closing bug.