Bug 89321

Summary:

Move functions to create strings from integers out of JavaScriptCore and into WTF

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Web Template Framework

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, ggaren, jberlin, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch with an attempt at Windows build fix for EWS	none
Patch	none
Patch	buildbot: commit-queue-

Darin Adler

Reported 2012-06-17 19:20:43 PDT

Move functions to create strings from integers out of JavaScriptCore and into WTF

Attachments
Patch (27.01 KB, patch) 2012-06-17 19:31 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch with an attempt at Windows build fix for EWS (28.13 KB, patch) 2012-06-17 21:40 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (28.13 KB, patch) 2012-06-18 20:13 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (26.72 KB, patch) 2012-06-22 10:45 PDT, Darin Adler	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2012-06-17 19:31:09 PDT

Created attachment 148037 [details] Patch

WebKit Review Bot

Comment 2 2012-06-17 19:35:23 PDT

Attachment 148037 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/text/Numeral.h:32: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:34: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:35: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:36: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:37: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:38: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:40: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:41: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:42: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:43: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:44: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:45: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:46: More than one command on the same line [whitespace/newline] [4] Total errors found: 13 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2012-06-17 20:05:22 PDT

Comment on attachment 148037 [details] Patch Attachment 148037 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12979081

Geoffrey Garen

Comment 4 2012-06-17 21:25:50 PDT

FWIW, llvm has a sub-library named llvm-mc, which can also do disassembly.

Geoffrey Garen

Comment 5 2012-06-17 21:27:14 PDT

Oops. Wrong bug.

Geoffrey Garen

Comment 6 2012-06-17 21:27:38 PDT

Comment on attachment 148037 [details] Patch Please fix Windows export: 17>WebCoreTestSupport.lib(Internals.obj) : error LNK2019: unresolved external symbol "public: static class WTF::PassRefPtr<class WTF::StringImpl> __cdecl WTF::StringImpl::createNumeral(unsigned long)" (?createNumeral@StringImpl@WTF@@SA?AV?$PassRefPtr@VStringImpl@WTF@@@2@K@Z) referenced in function "public: static class WTF::PassRefPtr<class WTF::StringImpl> __cdecl WTF::StringImpl::createNumeral(unsigned int)" (?createNumeral@StringImpl@WTF@@SA?AV?$PassRefPtr@VStringImpl@WTF@@@2@I@Z) r=me

Darin Adler

Comment 7 2012-06-17 21:40:04 PDT

Created attachment 148049 [details] Patch with an attempt at Windows build fix for EWS

WebKit Review Bot

Comment 8 2012-06-17 21:41:52 PDT

Attachment 148049 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/text/Numeral.h:32: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:34: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:35: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:36: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:37: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:38: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:40: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:41: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:42: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:43: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:44: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:45: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:46: More than one command on the same line [whitespace/newline] [4] Total errors found: 13 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 9 2012-06-17 22:08:37 PDT

Comment on attachment 148049 [details] Patch with an attempt at Windows build fix for EWS Attachment 148049 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12980059

Darin Adler

Comment 10 2012-06-18 20:13:28 PDT

Created attachment 148230 [details] Patch

WebKit Review Bot

Comment 11 2012-06-20 07:35:42 PDT

Attachment 148230 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/text/Numeral.h:32: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:34: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:35: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:36: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:37: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:38: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:40: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:41: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:42: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:43: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:44: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:45: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:46: More than one command on the same line [whitespace/newline] [4] Total errors found: 13 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 12 2012-06-20 08:21:32 PDT

Comment on attachment 148230 [details] Patch Attachment 148230 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13000249

Darin Adler

Comment 13 2012-06-22 10:45:17 PDT

Created attachment 149058 [details] Patch

WebKit Review Bot

Comment 14 2012-06-22 10:49:25 PDT

Attachment 149058 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WTF/wtf/text/Numeral.h:32: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:34: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:35: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:36: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:37: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:38: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:40: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:41: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:42: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:43: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:44: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:45: More than one command on the same line [whitespace/newline] [4] Source/WTF/wtf/text/Numeral.h:46: More than one command on the same line [whitespace/newline] [4] Total errors found: 13 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 15 2012-06-22 11:26:38 PDT

Comment on attachment 149058 [details] Patch Attachment 149058 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13032465

Jessie Berlin

Comment 16 2012-06-22 20:35:41 PDT

You need to export a couple of symbols in WebKit2.def: Index: Source/WebKit2/win/WebKit2.def =================================================================== --- Source/WebKit2/win/WebKit2.def (revision 121016) +++ Source/WebKit2/win/WebKit2.def (working copy) @@ -166,6 +166,8 @@ ?create@HTMLContentElement@WebCore@@SA?AV?$PassRefPtr@VHTMLContentElement@WebCore@@@WTF@@PAVDocument@2@@Z ?create@Range@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@V?$PassRefPtr@VDocument@WebCore@@@4@V?$PassRefPtr@VNode@WebCore@@@4@H1H@Z ?create@ShadowRoot@WebCore@@SA?AV?$PassRefPtr@VShadowRoot@WebCore@@@WTF@@PAVElement@2@AAH@Z + ?createNumeral@StringImpl@WTF@@SA?AV?$PassRefPtr@VStringImpl@WTF@@@2@I@Z + ?createNumeral@StringImpl@WTF@@SA?AV?$PassRefPtr@VStringImpl@WTF@@@2@H@Z ?createWrapper@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVNode@1@@Z ?documentState@HistoryItem@WebCore@@QBEABV?$Vector@VString@WTF@@$0A@@WTF@@XZ ?equal@WTF@@YA_NPBVStringImpl@1@PBE@Z

Darin Adler

Comment 17 2012-06-25 18:28:23 PDT

Thanks, Jessie! I got one (in an earlier version of the patch), but missed the other.

Darin Adler

Comment 18 2012-09-11 22:10:49 PDT

Looks like someone did this, surprisingly similarly to what I had planned, but apparently not using my code.

Benjamin Poulain

Comment 19 2012-09-11 23:01:52 PDT

(In reply to comment #18) > Looks like someone did this, surprisingly similarly to what I had planned, but apparently not using my code. I had originally planned to do it in two patches but you suggested to do everything at once https://bugs.webkit.org/show_bug.cgi?id=86312 :) It is amazing how similar our conversion code looks.

Note You need to log in before you can comment on or make changes to this bug.