Bug 89320 – Fix Framebuffer restrictions

• Component: WebGL
• Status: RESOLVED FIXED

[Gregg Tavares]

Fix Framebuffer restrictions

[Gregg Tavares]

Created attachment 148035 [details]
Patch

[Gregg Tavares]

Honestly I don't know why the LayoutTests didn't catch this. It's the exact same test that failing in the chrome gpu_tests. Maybe they get an INCOMPLETE_FRAMEBUFFER and so don't take a certain path.

[Kenneth Russell]

Comment on attachment 148035 [details]
Patch

Looks good; thanks for tracking this down.

It looks like framebuffer-object-attachment.html was skipped on the Mac platform in https://bugs.webkit.org/show_bug.cgi?id=82805 and this might be why this slipped through the cracks on the Mac platform.

Could you take a look through the results of platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt ? It looks to me like it is returning FRAMEBUFFER_COMPLETE in one case where the platform-independent results in fast/canvas/webgl/framebuffer-object-attachment-expected.txt return FRAMEBUFFER_UNSUPPORTED. Also, there are a couple of platform-specific expected results (platform/chromium-mac-snowleopard, platform/mac-snowleopard) which are identical to the platform-independent results and which could be deleted.

[WebKit Review Bot]

Comment on attachment 148035 [details]
Patch

Clearing flags on attachment: 148035

Committed r120571: <http://trac.webkit.org/changeset/120571>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.