Summary: | [EFL] media/video-seek-past-end-playing.html is flaky | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, d-r, eric.carlson, feature-media-reviews, gustavo, gyuyoung.kim, lucas.de.marchi, menard, mrobinson, pnormand, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Chris Dumez
2012-06-17 00:24:30 PDT
Created attachment 148095 [details]
Patch
I have made sure that the patch does not cause any regression in both EFL and GTK ports.
Comment on attachment 148095 [details] Patch Please check this patch doesn't break frame accurate seeking. One demo: http://www.massive-interactive.nl/html5_video/smpte_test_universal.html Comment on attachment 148095 [details] Patch Attachment 148095 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12982078 New failing tests: fast/text/international/thai-line-breaks.html fast/loader/unload-form-post-about-blank.html Created attachment 148100 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 148095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148095&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-1359 > - // EOS was reached but the position is not always 0 in case of > - // reverse playback (or the same as duration in case of forward That issue might still be valid (position > 0 in reverse playback). IIRC it happens with ogg/theora videos, I think I reported a gst bug for oggdemux about this. Created attachment 148106 [details] Patch Update the patch based on Philippe's comment. I added back the workaround for the reverse playing case (in case it is still needed and not tested). My patch does not appear to cause any problem with http://www.massive-interactive.nl/html5_video/smpte_test_universal.html Comment on attachment 148106 [details]
Patch
Looks good, thanks!
Comment on attachment 148106 [details] Patch Clearing flags on attachment: 148106 Committed r120654: <http://trac.webkit.org/changeset/120654> All reviewed patches have been landed. Closing bug. |