REGRESSION(r120485): Turned many, many tests red (Requested by abarth on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/120485 broke the build:
Turned many, many tests red (Requested by abarth on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[Adam Barth]

 test 	results	image results	actual failure	expected failure
+compositing/color-matching/image-color-matching.html		images diff (0%)	image	pass
+css3/filters/crash-hw-sw-switch.html		images diff (0%)	image	pass
+css3/filters/custom/custom-filter-shader-cache.html		images diff (0%)	image	pass
+css3/filters/custom/effect-custom-combined-missing.html		images diff (0%)	image	pass
+css3/filters/custom/effect-custom.html		images diff (0%)	image	pass
+css3/filters/custom/missing-custom-filter-shader.html		images diff (0%)	image	pass
+css3/filters/effect-blur-hw.html		images diff (0%)	image	pass
+css3/filters/effect-brightness-hw.html		images diff (0%)	image	pass
+css3/filters/effect-brightness.html		images diff (0%)	image	pass
+css3/filters/effect-contrast-hw.html		images diff (0%)	image	pass
+css3/filters/effect-drop-shadow-hw.html		images diff (0%)	image	pass
+fast/images/jpeg-with-color-profile.html		images diff (0%)	image	pass
+fast/images/png-with-color-profile.html		images diff (0%)	image	pass
+http/tests/local/file-url-sent-as-referer.html		images diff (0%)	image	pass
+scrollbars/listbox-scrollbar-combinations.html		images diff (0%)	image	pass
+scrollbars/overflow-scrollbar-combinations.html		images diff (0%)	image	pass
+svg/as-border-image/svg-as-border-image.html		images diff (0%)	image	pass
+svg/custom/createImageElement.svg		images diff (0%)	image	pass
+svg/custom/createImageElement2.xhtml		images diff (0%)	image	pass
+svg/custom/focus-ring.svg		images diff (0%)	image	pass
+svg/custom/group-opacity.svg		images diff (0%)	image	pass
+svg/custom/image-parent-translation.xhtml		images diff (0%)	image	pass
+svg/custom/image-small-width-height.svg		images diff (0%)	image	pass
+svg/custom/js-update-image-and-display.svg		images diff (0%)	image	pass
+svg/custom/js-update-image-and-display2.svg		images diff (0%)	image	pass
+svg/custom/js-update-image-and-display3.svg		images diff (0%)	image	pass
+svg/custom/js-update-image.svg		images diff (0%)	image	pass
+svg/custom/text-image-opacity.svg		images diff (0%)	image	pass
+svg/custom/use-on-g-containing-foreignObject-and-image.svg		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-dom-height-attr.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-dom-width-attr.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-dom-x-attr.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-dom-y-attr.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-svgdom-height-prop.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-svgdom-width-prop.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-svgdom-x-prop.html		images diff (0%)	image	pass
+svg/dynamic-updates/SVGImageElement-svgdom-y-prop.html		images diff (0%)	image	pass
+svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg		images diff (0%)	image	pass
+svg/filters/feImage-subregions-preseveAspectRatio-none.svg		images diff (0%)	image	pass
+svg/filters/feImage-subregions.svg		images diff (0%)	image	pass
+svg/filters/filter-source-position.svg		images diff (0%)	image	pass
+svg/repaint/image-href-change.svg		images diff (0%)	image	pass
+svg/transforms/animated-path-inside-transformed-html.xhtml		images diff (0%)	image	pass
+svg/zoom/page/zoom-background-images.html		images diff (0%)	image	pass
+svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml		images diff (0%)	image	pass
+svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml		images diff (0%)	image	pass
+svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml		images diff (0%)	image	pass

[Adam Barth]

I'm going to try rebaselining them.

[WebKit Review Bot]

Created attachment 147981 [details]
ROLLOUT of r120485

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Adam Barth]

Updated baselines in http://trac.webkit.org/changeset/120529

[Tony Payne]

atwilson rebaselined these yesterday. These test results were expected to change.

[Adam Barth]

> atwilson rebaselined these yesterday. These test results were expected to change.

Well, they were still red as of a few minutes ago.  Leaving a ton of red tests in the tree isn't the right way to handle these situations.  I'm not sure what went wrong where, but hopefully it will be fixed now.

[Andrew Wilson]

I landed the baselines that tpayne requested here: http://trac.webkit.org/changeset/120512, but they hadn't fully cleared the canary bots by the time I had to leave for the day (although I spot-checked a few of them on the linux bots and they seemed to have gone green).

Perhaps there were more tests that were red but that didn't get rebaselined as part of that patch? I'm somewhat at a loss as to what happened, too, barring some kind of screwup with the rebaseline tool.

[Adam Barth]

One possibility is that there were so many failures that the bots stopped early and hid the remaining failures.

I think the lesson to learn here is not to land these sorts of patches near the end of the day on a Friday.  We should land them when we know we have the time to clean up the mess.