Bug 89252

Summary: Make serve-video.php serve 206 responses
Product: WebKit Reporter: Ami Fischman <fischman>
Component: MediaAssignee: Ami Fischman <fischman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fischman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-02 none

Description Ami Fischman 2012-06-15 15:42:31 PDT 
http/tests/media/resources/serve-video.php has code that seemingly serves 206 in response to Range requests, but is slightly buggy, causing all its responses to always be 200's.  This hid the bug fixed in bug 89185.
Once chromium is updated to use the new option (exposeAllResponseHeaders) and rolls into WebKit, the .php file can be fixed to return real 206's without breaking tests.
Comment 1 Ami Fischman 2012-06-15 15:45:38 PDT 
Chromium-side fix is in https://chromiumcodereview.appspot.com/10554014/
Comment 2 Ami Fischman 2012-06-16 15:46:03 PDT 
Created attachment 147990 [details]
Patch
Comment 3 Ami Fischman 2012-06-16 15:47:48 PDT 
(patch is expected to make cr-linux EWS fail b/c the chromium-side CL hasn't landed yet)
Comment 4 WebKit Review Bot 2012-06-16 17:25:26 PDT 
Comment on attachment 147990 [details]
Patch

Attachment 147990 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12960981

New failing tests:
http/tests/security/video-cross-origin-readback.html
Comment 5 WebKit Review Bot 2012-06-16 17:25:30 PDT 
Created attachment 147995 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 WebKit Review Bot 2012-06-18 19:54:37 PDT 
Comment on attachment 147990 [details]
Patch

Clearing flags on attachment: 147990

Committed r120660: <http://trac.webkit.org/changeset/120660>
Comment 7 WebKit Review Bot 2012-06-18 19:54:42 PDT 
All reviewed patches have been landed.  Closing bug.