Summary: | [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | dfalcantara | ||||
Component: | WebKit Misc. | Assignee: | dfalcantara | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
dfalcantara
2012-06-15 11:03:59 PDT
Created attachment 147891 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Sounds like I should let fishd give the r+ on this one since I goofed it up twice already. :) Comment on attachment 147891 [details]
Patch
Thanks!
Comment on attachment 147891 [details] Patch Rejecting attachment 147891 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/12966609 Comment on attachment 147891 [details] Patch Clearing flags on attachment: 147891 Committed r120526: <http://trac.webkit.org/changeset/120526> All reviewed patches have been landed. Closing bug. |