Bug 89232

Summary: [BlackBerry] Use platform font settings for the standard settings.
Product: WebKit Reporter: Eli Fidler <efidler>
Component: WebKit BlackBerryAssignee: Eli Fidler <efidler>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Eli Fidler
Reported 2012-06-15 11:01:08 PDT
Use platform font settings for the standard settings instead of harcoding them. Line up WebCore::Settings and WebSettings.
Attachments
Patch (6.04 KB, patch)
2012-06-15 11:08 PDT, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Patch (6.11 KB, patch)
2012-06-15 15:02 PDT, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eli Fidler
Comment 1 2012-06-15 11:08:03 PDT
Created attachment 147861 [details] Patch
Rob Buis
Comment 2 2012-06-15 11:09:26 PDT
Comment on attachment 147861 [details] Patch Looks good.
WebKit Review Bot
Comment 3 2012-06-15 13:50:26 PDT
Comment on attachment 147861 [details] Patch Rejecting attachment 147861 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/page/blackberry/SettingsBlackBerry.cpp Hunk #1 FAILED at 19. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/page/blackberry/SettingsBlackBerry.cpp.rej patching file Source/WebKit/blackberry/Api/WebSettings.cpp Hunk #2 succeeded at 184 (offset -1 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12955867
Eli Fidler
Comment 4 2012-06-15 15:02:10 PDT
Created attachment 147908 [details] Patch
Rob Buis
Comment 5 2012-06-15 15:07:00 PDT
Comment on attachment 147908 [details] Patch Looks good, let's try again. Filling in the Reviewed by line may cause it to fail again....
WebKit Review Bot
Comment 6 2012-06-15 16:10:05 PDT
Comment on attachment 147908 [details] Patch Clearing flags on attachment: 147908 Committed r120506: <http://trac.webkit.org/changeset/120506>
WebKit Review Bot
Comment 7 2012-06-15 16:10:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.