| Summary: | Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hans Wennborg <hans> | ||||||||||
| Component: | New Bugs | Assignee: | Hans Wennborg <hans> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, primiano, satish, tkent, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 80261 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Hans Wennborg
2012-06-15 08:16:02 PDT
Created attachment 147826 [details]
Patch
I'll change the Chromium plumbing in the next patch so that it doesn't keep a reference to the SpeechRecognitionObject. Comment on attachment 147826 [details]
Patch
The change looks fine. Can we add a layout test, perhaps one that uses a child iframe and navigates in that to verify that speech recognition is aborted?
(In reply to comment #3) > (From update of attachment 147826 [details]) > The change looks fine. Can we add a layout test, perhaps one that uses a child iframe and navigates in that to verify that speech recognition is aborted? Coming up. As usual, the test is way more complicated than the code :/ Created attachment 148120 [details]
Patch
After discussing with Satish, trying to rebuild the mock object a little bit so that there is no need for the setWaitAfterStart() function. New patch coming up. Created attachment 148344 [details]
Patch
Comment on attachment 148344 [details]
Patch
The change itself looks good. It would be shorter to change all 'hasBeenAborted/hasXxxxxBeenAborted' to 'wasAborted' style :)
(In reply to comment #8) > (From update of attachment 148344 [details]) > The change itself looks good. It would be shorter to change all 'hasBeenAborted/hasXxxxxBeenAborted' to 'wasAborted' style :) Done. Created attachment 148526 [details]
Patch
Adam, would you like to take a look? Comment on attachment 148526 [details]
Patch
LGTM!
Comment on attachment 148526 [details] Patch Rejecting attachment 148526 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/speech/scripted/navigate-away-expected.txt patching file LayoutTests/fast/speech/scripted/navigate-away-iframe-expected.txt patching file LayoutTests/fast/speech/scripted/navigate-away-iframe.html patching file LayoutTests/fast/speech/scripted/navigate-away.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13030049 Committed r120913: <http://trac.webkit.org/changeset/120913> |