Bug 89203

Summary: Web Inspector: Add heap profiler owned memory to the pie chart
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Alexei Filippov <alph>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, dglazkov, haraken, japhet, jochen, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+, alph: commit-queue-

Description Alexei Filippov 2012-06-15 06:44:20 PDT 
Heap profiler may consume considerable amount of memory which is currently falls into Unknown category.
Give it a separate sector on the pie chart.
Comment 1 Alexei Filippov 2012-06-15 06:47:53 PDT 
Created attachment 147801 [details]
Patch
Comment 2 Alexei Filippov 2012-06-15 06:49:44 PDT 
Do not commit until v8 r11795 arrives.
Comment 3 WebKit Review Bot 2012-06-15 06:51:38 PDT 
Comment on attachment 147801 [details]
Patch

Attachment 147801 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12964499
Comment 4 Pavel Feldman 2012-06-15 10:39:36 PDT 
Comment on attachment 147801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147801&action=review

> Source/WebCore/bindings/js/ScriptProfiler.h:77
> +    static size_t getProfileDataSize() { return 0; }

Please do not use get prefixes as per WebKit guidelines.

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:199
> +size_t ScriptProfiler::getProfileDataSize()

profilerSnapshotsSize

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:69
> +static const char jsProfilerData[] = "JSProfilerData";

InspectorData

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:351
> +static PassRefPtr<InspectorMemoryBlock> jsProfilerData()

inspectorData
Comment 5 Alexei Filippov 2012-06-15 12:04:17 PDT 
Created attachment 147870 [details]
Patch
Comment 6 WebKit Review Bot 2012-06-15 13:53:50 PDT 
Comment on attachment 147870 [details]
Patch

Attachment 147870 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12967496
Comment 7 Ilya Tikhonovsky 2012-06-18 04:41:03 PDT 
Committed r120589: <http://trac.webkit.org/changeset/120589>