Bug 89199

Summary: [GTK][Mac WK2] New editing/spelling/grammar-edit-word.html fails
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: bugs-noreply, enrica, hbono, jonlee, mcatanzaro, morrita, mrobinson, ossy, pnormand, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87008, 88838    

Description Szilard Ledan 2012-06-15 05:42:00 PDT
The new editing/spelling/grammar-edit-word.html test fails on Qt and GTK since r120423 (http://trac.webkit.org/changeset/120423).

--- /ramdisk/qt-linux-64-release/build/layout-test-results/editing/spelling/grammar-edit-word-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/editing/spelling/grammar-edit-word-actual.txt 
@@ -4,7 +4,7 @@
 document.execCommand("InsertText", false, "You has the right.")
-PASS internals.hasGrammarMarker(document, 4, 3) is true
+FAIL internals.hasGrammarMarker(document, 4, 3) should be true. Was false.
 Delete the end of this sentence until it becomes "You ha".
Comment 1 Csaba Osztrogon√°c 2012-06-15 05:52:40 PDT
It fails on GTK too ...
Comment 2 Szilard Ledan 2012-06-15 06:11:21 PDT
I skipped it on Qt ( http://trac.webkit.org/changeset/120445/trunk/LayoutTests/platform/qt/Skipped ).

Please unskip it with the proper fix.
Comment 3 Martin Robinson 2012-06-15 08:43:10 PDT
*** Bug 89205 has been marked as a duplicate of this bug. ***
Comment 4 Hironori Bono 2012-06-17 18:46:52 PDT

Apologies for these test failures. (I thought these bots skip all tests in "editing/spelling" because my change finishes without errors on EWS bots.) Unfortunately, this test needs a grammar checker and it fails on Qt and GTK, which does not implement TextChecker::checkGrammarOfString(). Even though I have implemented the MockGrammarChecker class for Chromium DumpRenerTree, I do not have good ideas about how to implement it for Qt or GTK.

(*1) http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp


Hironori Bono
Comment 5 Philippe Normand 2012-06-17 19:11:04 PDT
There seems to be a wide assumption that all EWS bots run the tests :( To this date though, only the Chromium EWS actually runs them.
Comment 6 Radar WebKit Bug Importer 2012-06-22 13:55:41 PDT