Bug 89183

Summary:

REGRESSION(r120370): Broke webkit-patch rebaseline (Requested by zdobersek on #webkit).

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

New Bugs

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, rniwa, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

89135

Attachments:

Description	Flags
ROLLOUT of r120370	none

Description WebKit Review Bot 2012-06-15 00:48:26 PDT

http://trac.webkit.org/changeset/120370 broke the build:
Broke webkit-patch rebaseline (Requested by zdobersek on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

Comment 1 WebKit Review Bot 2012-06-15 00:49:11 PDT

Created attachment 147763 [details]
ROLLOUT of r120370

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment 2 Zan Dobersek 2012-06-15 00:51:01 PDT

Comment on attachment 147763 [details]
ROLLOUT of r120370

Clearing flags on attachment: 147763

Committed r120419: <http://trac.webkit.org/changeset/120419>

Comment 3 Zan Dobersek 2012-06-15 00:51:08 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Zan Dobersek 2012-06-15 00:54:57 PDT

Just to elaborate, the webkit-patch rebaseline command was erring out with the following traceback:
Traceback (most recent call last):
  File "Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 337, in execute
    port = tool.port_factory.get_from_builder_name(builder.name())
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 132, in get_from_builder_name
    port = self.get(port_name, BuilderOptions(builder_name))
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/layout_tests/port/factory.py", line 117, in get
    return cls(self._host, port_name, options=options, **kwargs)
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 58, in __init__
    self.set_option_default("pixel_tests", False)
  File "/home/zan/Dev/webkit/svn/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 672, in set_option_default
    return self._options.ensure_value(name, default_value)
AttributeError: 'BuilderOptions' object has no attribute 'ensure_value'