Bug 89167 – [Chromium] Layout Test media/track/track-cue-rendering-snap-to-lines-not-set.html is flaky

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Hajime Morrita]

On Linux, it's almost failing. It's flaky on other platforms.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmessaging%2Fcross-domain-message-event-dispatch.html%2Cmedia%2Ftrack%2Ftrack-cue-rendering-snap-to-lines-not-set.html%2Cmedia%2Fvideo-played-reset.html%2Csvg%2Fdynamic-updates%2FSVGFEFloodElement-inherit-flood-color.html%2Ccss3%2Ffilters%2Ffilter-animation.html

[Victor Carbune]

Not sure how I manage to forget about this bug.

However, this rendering case is now broken because of recent TextTrackCue constructor changes. Since other parts of rendering also changed, I think the plan is:
1) Fix the rendering and reactivate this test to see if it still is flaky.
2) If the flakiness remains I suggest converting this to a pixel test, as I don't think the instrospection we are doing here is enough when overlapping avoidance is implemented - so it will anyway need to change.

[Victor Carbune]

Created attachment 161485 [details]
Simple fix

[WebKit Review Bot]

Comment on attachment 161485 [details]
Simple fix

Rejecting attachment 161485 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
third_party/skia/src --revision 5310 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 5310.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...
Total errors found: 0 in 0 files

Full output: http://queues.webkit.org/results/13690809

[Victor Carbune]

Created attachment 161532 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 161532 [details]
Patch for landing

Clearing flags on attachment: 161532

Committed r127176: <http://trac.webkit.org/changeset/127176>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Victor Carbune]

Definitely not fixed, but the failures I see are because of rounding issues and the wrong assumption that controls + track container should perfectly cover the video height on all platforms.

I'll correct the test and not add a pixel test.

[Philip Rogers]

(In reply to comment #7)
> Definitely not fixed, but the failures I see are because of rounding issues and the wrong assumption that controls + track container should perfectly cover the video height on all platforms.
> 
> I'll correct the test and not add a pixel test.

I've marked this as PASS TEXT until this is fixed:
http://trac.webkit.org/changeset/127296

[Anand Chakravarty]

These tests have been failing consistently recently. Any update on fixing them? Thanks.

media/track/track-cue-rendering-snap-to-lines-not-set.html (FAIL PASS)
media/track/track-cue-rendering-vertical.html (FAIL)
media/track/track-cue-rendering-horizontal.html (FAIL)

[Stephen Chenney]

Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.