Bug 89165

Summary:

[BlackBerry] media volume slider in wrong position (master_38 regression)

Product:

WebKit

Reporter:

Max Feil <mfeil>

Component:

WebKit BlackBerry

Assignee:

Max Feil <mfeil>

Status:

CLOSED FIXED

Severity:

Normal

CC:

jonathan.dong.webkit, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
Patch	none

Description Max Feil 2012-06-14 22:10:53 PDT

Due to upstream simplification of the volume slider (bug 82150) it now appears in the wrong location below the media controls. The programmatic controls sizing we do in RenderThemeBlackBerry.cpp relies on absolute positioning of the volume slider container, so the best way to fix this is to set the bottom offset.

Comment 1 Max Feil 2012-06-14 22:14:04 PDT

Created attachment 147731 [details]
Patch

Comment 2 WebKit Review Bot 2012-06-15 07:17:45 PDT

Comment on attachment 147731 [details]
Patch

Clearing flags on attachment: 147731

Committed r120453: <http://trac.webkit.org/changeset/120453>

Comment 3 WebKit Review Bot 2012-06-15 07:17:50 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Max Feil 2012-11-02 12:45:55 PDT

Closing bug for patch that landed a long time ago.