Bug 89135

Summary: webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, levin, ojan, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89183    
Bug Blocks: 87413    
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

Dirk Pranke
Reported 2012-06-14 15:44:32 PDT
webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
Attachments
Patch (7.70 KB, patch)
2012-06-14 15:45 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2012-06-15 13:18 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-14 15:45:30 PDT
Created attachment 147667 [details] Patch
Ryosuke Niwa
Comment 2 2012-06-14 15:47:47 PDT
Yay! I love deleting code.
Dirk Pranke
Comment 3 2012-06-14 16:18:21 PDT
Committed r120370: <http://trac.webkit.org/changeset/120370>
WebKit Review Bot
Comment 4 2012-06-15 00:48:32 PDT
Re-opened since this is blocked by 89183
Dirk Pranke
Comment 5 2012-06-15 13:18:39 PDT
Created attachment 147885 [details] Patch
Dirk Pranke
Comment 6 2012-06-15 13:25:46 PDT
Committed r120488: <http://trac.webkit.org/changeset/120488>
Note You need to log in before you can comment on or make changes to this bug.