Bug 89121

Summary: [GTK] Audio playback controls not visible
Product: WebKit Reporter: Daniel Drake <dsd>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: crogers, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Screenshot none

Description Daniel Drake 2012-06-14 13:22:38 PDT
Created attachment 147639 [details]
Screenshot

On OLPC laptops XO, the audio controls are not visible in the browser.

Actually, I think they are visible, just 1 pixel in height.

WebKit-1.8.1 reproduced in Epiphany, GtkLauncher and Sugar Browse, on Fedora 17.
Comment 1 Philippe Normand 2012-06-14 14:04:18 PDT
I can confirm that issue.
Comment 2 Philippe Normand 2012-06-17 11:41:42 PDT
(In reply to comment #1)
> I can confirm that issue.

That was with Epiphany and WebKitGTK 1.8.1 but I can't reproduce this issue with WebKitGTK trunk. Can you confirm Daniel?
Comment 3 Daniel Drake 2012-06-17 17:05:48 PDT
Agreed.

Any idea where this was fixed, can we backport it? (happy to do some changelog-hunting myself, but perhaps you could suggest some files/classes where the fix is likely to have been?)
Comment 4 Philippe Normand 2012-06-17 18:02:47 PDT
No idea which commit fixed this issue.
Maybe look for changes related to HTMLMediaElement.cpp, MediaPlayer.cpp or WebCore/css/mediaControls*.css.
Comment 5 Daniel Drake 2012-06-19 06:31:20 PDT
Thanks, found it. Fixed with http://trac.webkit.org/changeset/115829/trunk/Source/WebCore/css/mediaControlsGtk.css which can be trivially backported. Is there any chance of this landing in 1.8?
Comment 6 Philippe Normand 2012-06-19 09:13:54 PDT
(In reply to comment #5)
> Thanks, found it. Fixed with http://trac.webkit.org/changeset/115829/trunk/Source/WebCore/css/mediaControlsGtk.css which can be trivially backported. Is there any chance of this landing in 1.8?

I added it to the list: https://trac.webkit.org/wiki/WebKitGTK/1.8.x