Bug 89055

Summary: Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
Product: WebKit Reporter: David Barr <davidbarr>
Component: CSSAssignee: David Barr <davidbarr>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric, gyuyoung.kim, mikelawther, noel.gordon, rakuco, simon.fraser, tony, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
Bug Depends on:    
Bug Blocks: 89052, 89624, 91961    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description David Barr 2012-06-13 20:03:08 PDT 
Add image-orientation support to WebKit.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation

The css3-images module is at candidate recommendation.

I propose to introduce the property, initially behind a compile flag.
Comment 1 David Barr 2012-06-13 21:03:58 PDT 
Created attachment 147480 [details]
Patch
Comment 2 David Barr 2012-06-13 21:15:57 PDT 
In the spirit of http://trac.webkit.org/changeset/118774 - add ENABLE_CSS_IMAGE_ORIENTATION.
Comment 3 Alexey Proskuryakov 2012-06-14 09:42:17 PDT 
I wonder why this property doesn't have a value to auto-rotate based on EXIF data.
Comment 4 Alexey Proskuryakov 2012-06-14 09:43:10 PDT 
I'll re-post this comment in bug 89052, where it's much more suitable.
Comment 5 David Barr 2012-06-19 18:19:55 PDT 
Created attachment 148479 [details]
Patch

Rebased against ToT.
Comment 6 David Barr 2012-07-16 20:19:56 PDT 
Created attachment 152688 [details]
Patch

Rebased against ToT. Received no significant objection to the flag itself.
Comment 7 noel gordon 2012-07-16 22:23:42 PDT 
OK.
Comment 8 Kent Tamura 2012-07-16 22:38:59 PDT 
Comment on attachment 152688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152688&action=review


> Source/WebKit/chromium/features.gypi:46
> +      'ENABLE_CSS_IMAGE_ORIENTATION=0',

I recommend NOT adding ENABLE_CSS_IAMGE_ORIENTATION=0 because it prevents local override of the feature flag.
http://trac.webkit.org/wiki/Chromium#Buildingwithfeaturedefines
Comment 9 noel gordon 2012-07-16 22:55:31 PDT 
I see, seems backwards to me and different from every other platform.  Should we fix that?
Comment 10 David Barr 2012-07-16 23:02:50 PDT 
Created attachment 152700 [details]
Patch

Dropped change to Source/WebKit/chromium/features.gypi to facilitate local override of the feature flag.
Comment 11 Kent Tamura 2012-07-16 23:04:49 PDT 
Comment on attachment 152700 [details]
Patch

Looks ok.
Please update http://trac.webkit.org/wiki/FeatureFlags
Comment 12 WebKit Review Bot 2012-07-17 00:12:05 PDT 
Comment on attachment 152700 [details]
Patch

Clearing flags on attachment: 152700

Committed r122813: <http://trac.webkit.org/changeset/122813>
Comment 13 WebKit Review Bot 2012-07-17 00:12:11 PDT 
All reviewed patches have been landed.  Closing bug.