Bug 8896

Summary:

Absolutely positioned elements should use their parent's direction when left, right and width are auto in quirks mode

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.ynet.co.il/Ext/Comp/Ticker/Dhtml_Ticker/0,10016,L-184,00.html

Attachments:

Description	Flags
Test case	none
patch	none
patch with test cases	none
fixed patch	hyatt: review+

mitz

Reported 2006-05-14 07:42:17 PDT

The fix for bug 7604 corrected the implementation of http://www.w3.org/TR/CSS21/visudet.html#abs-non-replaced-width to use the direction of the containing block. IE uses the parent's direction (even in strict mode). WebKit should retain this behavior in quirks mode for compatibility.

Attachments
Test case (197 bytes, text/html) 2006-05-14 07:43 PDT, mitz	no flags	Details
patch (8.19 KB, patch) 2006-05-14 08:44 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
patch with test cases (11.40 KB, patch) 2006-05-14 10:52 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
fixed patch (11.37 KB, patch) 2006-05-14 11:54 PDT, Sam Weinig	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2006-05-14 07:43:45 PDT

Created attachment 8292 [details] Test case

Sam Weinig

Comment 2 2006-05-14 08:44:23 PDT

Created attachment 8293 [details] patch missing changelog comments, but posting for mitz to test

mitz

Comment 3 2006-05-14 08:46:37 PDT

(In reply to comment #2) > missing changelog comments, but posting for mitz to test Thanks! The final patch should include two layout tests, one for the quirk and one for strict mode (as this wasn't covered by any of the existing tests!).

Sam Weinig

Comment 4 2006-05-14 10:52:52 PDT

Created attachment 8295 [details] patch with test cases The patch now includes two test cases, one quirks, one strict.

mitz

Comment 5 2006-05-14 11:14:17 PDT

Comment on attachment 8295 [details] patch with test cases Clearing the requestee field since I'm not a reviewer. This is a WinIE quirk (Firefox is totally broken), so your comments need to be corrected.

Sam Weinig

Comment 6 2006-05-14 11:54:37 PDT

Created attachment 8305 [details] fixed patch Fixed the comments based on what mitz noted above.

Dave Hyatt

Comment 7 2006-05-14 12:03:20 PDT

Comment on attachment 8305 [details] fixed patch r=me

mitz

Comment 8 2006-05-18 12:06:51 PDT

Landed by Darin (r14466)

Note You need to log in before you can comment on or make changes to this bug.