Bug 88952 – Move setDefersLoading to Internals interface

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Gyuyoung Kim]

Adjust setDefersLoading tests to use Internals instead of LayoutTestController interface. In my humble opinion, setDefersLoading() is able to be supported by Internals because it looks this function is implemented by WebCore layer, not WebKit layer. If reviewers think this test function is able to be dealt with by WebKit layer, I will remove this patch.

[Gyuyoung Kim]

Created attachment 147222 [details]
Patch

[Build Bot]

Comment on attachment 147222 [details]
Patch

Attachment 147222 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12953056

[Gyuyoung Kim]

Created attachment 147226 [details]
Patch

[Alexey Proskuryakov]

> setDefersLoading() is able to be supported by Internals

Once again, I question this view on moving code to Internals. We should not move anything that it is _able_ to support, we should only move what it makes sense to move.

I do not believe that Internals is ready to cleanly implement the state for setDefersLoading. Even settings are not quite done yet.

[Gyuyoung Kim]

(In reply to comment #4)
> Once again, I question this view on moving code to Internals. We should not move anything that it is _able_ to support, we should only move what it makes sense to move.
> 
> I do not believe that Internals is ready to cleanly implement the state for setDefersLoading. Even settings are not quite done yet.

Thank you for your comment. It seems to me setDefersLoading() is still not related to WebKit layer. But, if you think Internals need to be mature to support setDefersLoading(), I would close this bug.

Could you let me know what things Internals needs to support setDefersLoading()?

[Ryosuke Niwa]

Comment on attachment 147226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147226&action=review

> Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm:-492
> -    [[mainFrame webView] setDefersCallbacks:defers];

Unfortunately this API has non-DRT clients such as _documentFragmentFromPasteboard in WebHTMLView.mm.
We should probably add some WebKit API test for this before removing the dependency.

[Gyuyoung Kim]

Thank you for your explain.