Bug 88839

Summary:

webcore should depend on webcore_arm_neon for only arm target_arch

Product:

WebKit

Reporter:

Wei James (wistoch) <james.wei>

Component:

WebCore Misc.

Assignee:

Wei James (wistoch) <james.wei>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, thakis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Wei James (wistoch) 2012-06-11 22:51:30 PDT

webcore should depend on webcore_arm_neon for only arm target_arch

Comment 1 Wei James (wistoch) 2012-06-11 22:52:05 PDT

Created attachment 147011 [details]
Patch

Comment 2 Nico Weber 2012-06-12 08:24:16 PDT

Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless.

Comment 3 Wei James (wistoch) 2012-06-12 14:09:20 PDT

(In reply to comment #2)
> Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless.

yes, it is harmless. But it is very strange I found webcore_arm_neon.stamp in somewhere when I was building other targets.

Comment 4 Nico Weber 2012-06-12 14:10:37 PDT

I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+

Comment 5 Wei James (wistoch) 2012-06-12 14:13:35 PDT

(In reply to comment #4)
> I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+

+abarth. 

could you kindly help to review it? thanks

Comment 6 Adam Barth 2012-06-12 15:06:04 PDT

Comment on attachment 147011 [details]
Patch

ok

Comment 7 WebKit Review Bot 2012-06-12 22:01:10 PDT

Comment on attachment 147011 [details]
Patch

Clearing flags on attachment: 147011

Committed r120160: <http://trac.webkit.org/changeset/120160>

Comment 8 WebKit Review Bot 2012-06-12 22:01:15 PDT

All reviewed patches have been landed.  Closing bug.