Bug 88839

Summary:

webcore should depend on webcore_arm_neon for only arm target_arch

Product:

WebKit

Reporter:

Wei James (wistoch) <james.wei>

Component:

WebCore Misc.

Assignee:

Wei James (wistoch) <james.wei>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, thakis, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Wei James (wistoch)

Reported 2012-06-11 22:51:30 PDT

webcore should depend on webcore_arm_neon for only arm target_arch

Attachments
Patch (1.42 KB, patch) 2012-06-11 22:52 PDT, Wei James (wistoch)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Wei James (wistoch)

Comment 1 2012-06-11 22:52:05 PDT

Created attachment 147011 [details] Patch

Nico Weber

Comment 2 2012-06-12 08:24:16 PDT

Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless.

Wei James (wistoch)

Comment 3 2012-06-12 14:09:20 PDT

(In reply to comment #2) > Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless. yes, it is harmless. But it is very strange I found webcore_arm_neon.stamp in somewhere when I was building other targets.

Nico Weber

Comment 4 2012-06-12 14:10:37 PDT

I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+

Wei James (wistoch)

Comment 5 2012-06-12 14:13:35 PDT

(In reply to comment #4) > I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+ +abarth. could you kindly help to review it? thanks

Adam Barth

Comment 6 2012-06-12 15:06:04 PDT

Comment on attachment 147011 [details] Patch ok

WebKit Review Bot

Comment 7 2012-06-12 22:01:10 PDT

Comment on attachment 147011 [details] Patch Clearing flags on attachment: 147011 Committed r120160: <http://trac.webkit.org/changeset/120160>

WebKit Review Bot

Comment 8 2012-06-12 22:01:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.