Bug 88805

Summary: unneeded object creation with Vector::append
Product: WebKit Reporter: arno. <a.renevier>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch proposal none

arno.
Reported 2012-06-11 14:02:34 PDT
Hi, in contextMenuItemVector, menuItemVector.append(ContextMenuItem(GTK_MENU_ITEM(widget))); creates a ContextMenuItem, and pass it to Vector::append(const U& val) which then creates a new object with new T(val) which just copies the ContextMenuItem object so, it's possible to just pass GTK_MENU_ITEM(widget), and only one ContextMenuItem object will be created. The same pattern is also present in KeyBindingTranslator::addPendingEditorCommand
Attachments
patch proposal (2.25 KB, patch)
2012-06-11 14:06 PDT, arno. 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2012-06-11 14:06:50 PDT
Created attachment 146904 [details] patch proposal
WebKit Review Bot
Comment 2 2012-07-26 17:42:17 PDT
Comment on attachment 146904 [details] patch proposal Clearing flags on attachment: 146904 Committed r123821: <http://trac.webkit.org/changeset/123821>
WebKit Review Bot
Comment 3 2012-07-26 17:42:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.