Summary: | [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||||
Component: | CSS | Assignee: | Alexis Menard (darktears) <menard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cmarcelo, eric, jackalmage, macpherson, ojan, paulirish, tony, vestbo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 88850, 88861 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexis Menard (darktears)
2012-06-11 13:59:55 PDT
Created attachment 146902 [details]
Patch
Attachment 146902 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebCore/rendering/style/StyleBoxData.cpp:77: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 146902 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1 > Source/WebCore/rendering/style/StyleBoxData.cpp:77: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] > Total errors found: 1 in 27 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Please ignore, we use that trick in some other files, e.g RenderStyle.cpp. Comment on attachment 146902 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146902&action=review > Source/WebCore/rendering/style/RenderStyle.h:1592 > +#if ENABLE(CSS_BOX_DECORATION_BREAK) > static EBoxDecorationBreak initialBoxDecorationBreak() { return DSLICE; } > +#endif Nit: It's OK to not guard this in an ENABLE (will get compiled out if not used). > Source/WebCore/rendering/style/RenderStyleConstants.h:106 > +#if ENABLE(CSS_BOX_DECORATION_BREAK) Nit: It's OK to not guard this in an ENABLE (doesn't take up space). > Source/WebCore/rendering/style/StyleBoxData.h:84 > bool m_hasAutoZIndex : 1; > unsigned m_boxSizing : 1; // EBoxSizing Not related to your change, but we should change m_hasAutoZIndex to unsigned to fix the packing on Windows. Created attachment 146959 [details]
Patch for landing
Attachment 146959 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebCore/rendering/style/StyleBoxData.cpp:77: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #4) > (From update of attachment 146902 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146902&action=review > > > Source/WebCore/rendering/style/RenderStyle.h:1592 > > +#if ENABLE(CSS_BOX_DECORATION_BREAK) > > static EBoxDecorationBreak initialBoxDecorationBreak() { return DSLICE; } > > +#endif > > Nit: It's OK to not guard this in an ENABLE (will get compiled out if not used). > > > Source/WebCore/rendering/style/RenderStyleConstants.h:106 > > +#if ENABLE(CSS_BOX_DECORATION_BREAK) > > Nit: It's OK to not guard this in an ENABLE (doesn't take up space). > > > Source/WebCore/rendering/style/StyleBoxData.h:84 > > bool m_hasAutoZIndex : 1; > > unsigned m_boxSizing : 1; // EBoxSizing > > Not related to your change, but we should change m_hasAutoZIndex to unsigned to fix the packing on Windows. I'll make a patch for that separately :) Comment on attachment 146959 [details] Patch for landing Clearing flags on attachment: 146959 Committed r120029: <http://trac.webkit.org/changeset/120029> All reviewed patches have been landed. Closing bug. |