Summary: | [Chromium] Let Android and Linux share WebFontRendering decl/impl | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xianzhu Wang <wangxianzhu> | ||||||||||||
Component: | WebKit API | Assignee: | Xianzhu Wang <wangxianzhu> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, klobag, peter, tkent+wkapi, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 89021 | ||||||||||||||
Bug Blocks: | 66687 | ||||||||||||||
Attachments: |
|
Description
Xianzhu Wang
2012-06-11 13:47:00 PDT
Created attachment 146930 [details]
patch
Wondering if this is the correct way.
Comment on attachment 146930 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=146930&action=review Wondering if the commit queue could correctly handle the change: A renamed to B another A created > Source/WebKit/chromium/WebKit.gyp:-781 > - ['exclude', '/linux/'], The rules have been in Chromium's build/filename_rules.gypi. Created attachment 146958 [details]
patch v2 (try to fix patch issue)
Created attachment 146964 [details]
patch v3 (remove changes after move which break patch on bot)
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Will make a smaller change. Created attachment 147197 [details]
a much smaller patch
Comment on attachment 147197 [details]
a much smaller patch
Ok. I'm not 100% confident in all of the changes you're making to the GYP file, but the compiler should tell us if we've goofed up there.
Comment on attachment 147197 [details]
a much smaller patch
Thanks Adam. I've verified the patch on Chromium's try bots.
Comment on attachment 147197 [details] a much smaller patch Clearing flags on attachment: 147197 Committed r120220: <http://trac.webkit.org/changeset/120220> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 89021 Created attachment 147367 [details]
patch for re-applying with some changes in WebKit.gyp reverted
Comment on attachment 147367 [details] patch for re-applying with some changes in WebKit.gyp reverted Clearing flags on attachment: 147367 Committed r120270: <http://trac.webkit.org/changeset/120270> All reviewed patches have been landed. Closing bug. |