Bug 88798

Summary: Separate RemoveID test cases in video-media-source-add-and-remove-ids.html
Product: WebKit Reporter: Anna Cavender <annacc>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: acolwell, dglazkov, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-03
none
with test expectations added none

Anna Cavender
Reported 2012-06-11 13:11:43 PDT
The Chrome implementation will (until we fix it) not support adding an id again after removing an id. I plan to separate the existing testRemoveIDFailureCases to avoid doing that, and add a test that explicitly tests adding ids after a remove (we will fail that test for while).
Attachments
Patch (5.67 KB, patch)
2012-06-11 14:58 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (592.51 KB, application/zip)
2012-06-11 17:56 PDT, WebKit Review Bot 		no flags
Details
with test expectations added (5.68 KB, patch)
2012-06-12 01:29 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2012-06-11 14:58:08 PDT
Created attachment 146922 [details] Patch
WebKit Review Bot
Comment 2 2012-06-11 17:56:41 PDT
Comment on attachment 146922 [details] Patch Attachment 146922 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12945405 New failing tests: http/tests/media/media-source/video-media-source-add-and-remove-ids.html
WebKit Review Bot
Comment 3 2012-06-11 17:56:45 PDT
Created attachment 146980 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Anna Cavender
Comment 4 2012-06-11 19:46:02 PDT
I should have added that these changes will not pass until the chromium changes land (which is pending these changes).
Anna Cavender
Comment 5 2012-06-12 01:29:35 PDT
Created attachment 147035 [details] with test expectations added
Eric Carlson
Comment 6 2012-06-12 10:39:50 PDT
Comment on attachment 147035 [details] with test expectations added rs=me
Anna Cavender
Comment 7 2012-06-12 10:50:40 PDT
Comment on attachment 147035 [details] with test expectations added Thanks Eric!
WebKit Review Bot
Comment 8 2012-06-12 11:52:30 PDT
Comment on attachment 147035 [details] with test expectations added Clearing flags on attachment: 147035 Committed r120097: <http://trac.webkit.org/changeset/120097>
WebKit Review Bot
Comment 9 2012-06-12 11:52:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.