Bug 88770

Summary: REGRESSION(r119944): test http/tests/security/mixedContent/filesystem-url-in-iframe.html fails
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: Tools / TestsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mkwst, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Szilard Ledan 2012-06-11 01:44:59 PDT
This test: http/tests/security/mixedContent/filesystem-url-in-iframe.html fails after r119944 on qt.

--- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-actual.txt 
@@ -1,8 +1,10 @@
-ALERT: PASS (1/2): File written
+CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY
+CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY
+FAIL: Timed out waiting for notifyDone to be called
 
 This tests that filesystem URLs created in a secure context are treated as secure origins. This test passes if the iframe renders PASS correctly, and no console warning appears.
 
 --------
 Frame: '<!--framePath //<!--frame0-->-->'
 --------
-PASS (2/2): File displayed
+
Comment 1 Mike West 2012-06-11 01:50:28 PDT
I'll take a look.
Comment 2 Csaba Osztrogonác 2012-06-11 02:02:59 PDT
Skipped on Qt to paint the bot green by http://trac.webkit.org/changeset/119964/trunk/LayoutTests/platform/qt/Skipped . Please unskip it with the proper fix.
Comment 3 Mike West 2012-06-11 02:04:34 PDT
Actually, it looks like ENABLE(FILE_SYSTEM) is disabled on QT. I'll move the skip to the proper section of the Skipped file so that it can be reenabled if and when the port enables the feature.
Comment 4 Mike West 2012-06-11 02:13:05 PDT
Created attachment 146813 [details]
Patch
Comment 5 Mike West 2012-06-11 02:13:53 PDT
Comment on attachment 146813 [details]
Patch

Would you mind taking a look, and throwing it into the queue if you're happy?
Comment 6 Csaba Osztrogonác 2012-06-11 03:23:48 PDT
Comment on attachment 146813 [details]
Patch

r=me, thanks for looking into the root of the problem.
Comment 7 WebKit Review Bot 2012-06-11 04:28:00 PDT
Comment on attachment 146813 [details]
Patch

Clearing flags on attachment: 146813

Committed r119971: <http://trac.webkit.org/changeset/119971>
Comment 8 WebKit Review Bot 2012-06-11 04:28:05 PDT
All reviewed patches have been landed.  Closing bug.