Bug 88770

Summary: REGRESSION(r119944): test http/tests/security/mixedContent/filesystem-url-in-iframe.html fails
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: Tools / TestsAssignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mkwst, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Szilard Ledan
Reported 2012-06-11 01:44:59 PDT
This test: http/tests/security/mixedContent/filesystem-url-in-iframe.html fails after r119944 on qt. --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-actual.txt @@ -1,8 +1,10 @@ -ALERT: PASS (1/2): File written +CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY +CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY +FAIL: Timed out waiting for notifyDone to be called This tests that filesystem URLs created in a secure context are treated as secure origins. This test passes if the iframe renders PASS correctly, and no console warning appears. -------- Frame: '<!--framePath //<!--frame0-->-->' -------- -PASS (2/2): File displayed +
Attachments
Patch (2.08 KB, patch)
2012-06-11 02:13 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-06-11 01:50:28 PDT
I'll take a look.
Csaba Osztrogonác
Comment 2 2012-06-11 02:02:59 PDT
Skipped on Qt to paint the bot green by http://trac.webkit.org/changeset/119964/trunk/LayoutTests/platform/qt/Skipped . Please unskip it with the proper fix.
Mike West
Comment 3 2012-06-11 02:04:34 PDT
Actually, it looks like ENABLE(FILE_SYSTEM) is disabled on QT. I'll move the skip to the proper section of the Skipped file so that it can be reenabled if and when the port enables the feature.
Mike West
Comment 4 2012-06-11 02:13:05 PDT
Created attachment 146813 [details] Patch
Mike West
Comment 5 2012-06-11 02:13:53 PDT
Comment on attachment 146813 [details] Patch Would you mind taking a look, and throwing it into the queue if you're happy?
Csaba Osztrogonác
Comment 6 2012-06-11 03:23:48 PDT
Comment on attachment 146813 [details] Patch r=me, thanks for looking into the root of the problem.
WebKit Review Bot
Comment 7 2012-06-11 04:28:00 PDT
Comment on attachment 146813 [details] Patch Clearing flags on attachment: 146813 Committed r119971: <http://trac.webkit.org/changeset/119971>
WebKit Review Bot
Comment 8 2012-06-11 04:28:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.