Bug 88732

Summary: [BlackBerry] Seek calls are being unnecessarily delayed
Product: WebKit Reporter: Max Feil <mfeil>
Component: WebKit BlackBerryAssignee: Max Feil <mfeil>
Status: CLOSED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Description Max Feil 2012-06-10 07:04:04 PDT 
There is a problem with the way the m_userDrivenSeekTimer is implemented. When MediaPlayerPrivate::seek() is called, there is always a 100ms delay even if the timer is not running. The timer is supposed to space out (i.e. throttle) repeated seeks that come in too soon after a previous seek, but currently it is slowing down even single seeks and seeks that come in with adequate delay after a previous seek. I fixed this in my patch by improving the way the timer fired function is called.

I would like to propose not including a layout test with this fix. Doing timing tests for 100ms delays is tricky from Javascript, and I don't think the benefit of such a test outweighs the extra time it would take to develop one. The test would also be a problem to maintain as it may give different results over different runs and across different target hardware.
Comment 1 Max Feil 2012-06-11 14:33:57 PDT 
Created attachment 146913 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-11 17:02:24 PDT 
Comment on attachment 146913 [details]
Patch

Clearing flags on attachment: 146913

Committed r120020: <http://trac.webkit.org/changeset/120020>
Comment 3 WebKit Review Bot 2012-06-11 17:02:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Max Feil 2012-11-02 12:45:26 PDT 
Closing bug for patch that landed a long time ago.