Bug 88723

Summary: Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, japhet, jochen, ojan, psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88758    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Sam Weinig
Reported 2012-06-09 20:55:18 PDT
Remove support for disconnected frames, they are not used by Safari anymore
Attachments
Patch (15.11 KB, patch)
2012-06-09 21:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (22.91 KB, patch)
2012-06-10 20:27 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-06-09 21:03:59 PDT
Created attachment 146722 [details] Patch
mitz
Comment 2 2012-06-09 21:51:24 PDT
Comment on attachment 146722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review > Source/WebCore/editing/Editor.cpp:2417 > +bool Editor::insideVisibleArea(const LayoutPoint&) const You should just remove this function. > Source/WebCore/editing/Editor.cpp:2426 > bool Editor::insideVisibleArea(Range* range) const And this one. > Source/WebKit/mac/WebView/WebFrame.mm:914 > +// FIXME: This is being kept around to avoid linking issues with the nightly, > +// and should be removed when it is no longer needed I think it is no longer needed. > Source/WebKit/mac/WebView/WebFramePrivate.h:33 > +#import <JavaScriptCore/WebKitAvailability.h> Why this?
Sam Weinig
Comment 3 2012-06-09 22:37:53 PDT
(In reply to comment #2) > (From update of attachment 146722 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review > > > Source/WebCore/editing/Editor.cpp:2417 > > +bool Editor::insideVisibleArea(const LayoutPoint&) const > > You should just remove this function. > > > Source/WebCore/editing/Editor.cpp:2426 > > bool Editor::insideVisibleArea(Range* range) const > > And this one. I was going to do it in a follow up where I remove the excludeTextFromSearch stuff, but I could do it now. > > > Source/WebKit/mac/WebView/WebFrame.mm:914 > > +// FIXME: This is being kept around to avoid linking issues with the nightly, > > +// and should be removed when it is no longer needed > > I think it is no longer needed. Ok. > > > Source/WebKit/mac/WebView/WebFramePrivate.h:33 > > +#import <JavaScriptCore/WebKitAvailability.h> > > Why this? A mistake. I was going to use that for deprecating, but we don't need to deprecate.
Sam Weinig
Comment 4 2012-06-10 20:27:17 PDT
Created attachment 146768 [details] Patch
Sam Weinig
Comment 5 2012-06-10 23:11:48 PDT
Committed r119955: <http://trac.webkit.org/changeset/119955>
WebKit Review Bot
Comment 6 2012-06-10 23:52:35 PDT
Re-opened since this is blocked by 88758
Pratik Solanki
Comment 7 2012-09-13 23:18:06 PDT
Isn't this fixed? This was relanded in r120005 - <http://trac.webkit.org/changeset/120005>.
Adam Barth
Comment 8 2012-09-14 00:18:24 PDT
Seems likely.
Note You need to log in before you can comment on or make changes to this bug.