Summary: | Remove support for disconnected/excluded from search frames, they are not used by Safari anymore | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dominicc, japhet, jochen, ojan, psolanki, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 88758 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Sam Weinig
2012-06-09 20:55:18 PDT
Created attachment 146722 [details]
Patch
Comment on attachment 146722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review > Source/WebCore/editing/Editor.cpp:2417 > +bool Editor::insideVisibleArea(const LayoutPoint&) const You should just remove this function. > Source/WebCore/editing/Editor.cpp:2426 > bool Editor::insideVisibleArea(Range* range) const And this one. > Source/WebKit/mac/WebView/WebFrame.mm:914 > +// FIXME: This is being kept around to avoid linking issues with the nightly, > +// and should be removed when it is no longer needed I think it is no longer needed. > Source/WebKit/mac/WebView/WebFramePrivate.h:33 > +#import <JavaScriptCore/WebKitAvailability.h> Why this? (In reply to comment #2) > (From update of attachment 146722 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146722&action=review > > > Source/WebCore/editing/Editor.cpp:2417 > > +bool Editor::insideVisibleArea(const LayoutPoint&) const > > You should just remove this function. > > > Source/WebCore/editing/Editor.cpp:2426 > > bool Editor::insideVisibleArea(Range* range) const > > And this one. I was going to do it in a follow up where I remove the excludeTextFromSearch stuff, but I could do it now. > > > Source/WebKit/mac/WebView/WebFrame.mm:914 > > +// FIXME: This is being kept around to avoid linking issues with the nightly, > > +// and should be removed when it is no longer needed > > I think it is no longer needed. Ok. > > > Source/WebKit/mac/WebView/WebFramePrivate.h:33 > > +#import <JavaScriptCore/WebKitAvailability.h> > > Why this? A mistake. I was going to use that for deprecating, but we don't need to deprecate. Created attachment 146768 [details]
Patch
Committed r119955: <http://trac.webkit.org/changeset/119955> Re-opened since this is blocked by 88758 Isn't this fixed? This was relanded in r120005 - <http://trac.webkit.org/changeset/120005>. Seems likely. |