Summary: | [BlackBerry] Default font settings are getting deleted | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eli Fidler <efidler> | ||||||
Component: | WebKit BlackBerry | Assignee: | Eli Fidler <efidler> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Critical | CC: | jpetsovits, rwlbuis, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Eli Fidler
2012-06-08 10:38:10 PDT
Created attachment 146622 [details]
Patch
Comment on attachment 146622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146622&action=review Looks good, testcase can be improved a bit > LayoutTests/fonts/valid-standard-font.html:6 > + window.setTimeout(runTest,0); Needs a space char after comma. > LayoutTests/fonts/valid-standard-font.html:7 > + function runTest(){ Needs a space char before { > LayoutTests/fonts/valid-standard-font.html:13 > + if (window.layoutTestController) { This is usually done first. Created attachment 146625 [details]
Patch
Comment on attachment 146625 [details]
Patch
LGTM.
Comment on attachment 146625 [details] Patch Rejecting attachment 146625 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: m/tools/gyp --revision 1409 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 113. Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' Died at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2476. Full output: http://queues.webkit.org/results/12914630 Comment on attachment 146625 [details] Patch Clearing flags on attachment: 146625 Committed r119879: <http://trac.webkit.org/changeset/119879> All reviewed patches have been landed. Closing bug. |