Summary: | [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dongwoo Joshua Im (dwim) <dw.im> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, gyuyoung.kim, kling, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Dongwoo Joshua Im (dwim)
2012-06-07 20:13:43 PDT
Created attachment 146463 [details]
Patch
Comment on attachment 146463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146463&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:228 > + > + You seem to have added an extra empty line here. > Tools/Scripts/webkitperl/FeatureList.pm:172 > + define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => isEfl(), value => \$customSchemeHandlerSupport }, Please also change the default in Source/cmake/OptionsEfl.cmake. Could you also explain the relationship between ENABLE(REGISTER_PROTOCOL_HANDLER) and ENABLE(CUSTOM_SCHEME_HANDLER)? (In reply to comment #3) > Could you also explain the relationship between ENABLE(REGISTER_PROTOCOL_HANDLER) and ENABLE(CUSTOM_SCHEME_HANDLER)? Adam Barth suggested to use CUSTOM_SCHEME_HANDLER macro in the bug, https://bugs.webkit.org/show_bug.cgi?id=73176. Actually, those three APIs - register, isRegistered, and unregister - are belong to one W3C spec which name is Custom Scheme Handler. So, I think we can deprecate REGISTER_PROTOCOL_HANDLER macro, and use CUSTOM_SCHEME_HANDLER only in someday. Created attachment 146471 [details]
Patch
Are there no test cases covered by this patch ? (In reply to comment #6) > Are there no test cases covered by this patch ? After this patch is merged, the result of platform/efl/fast/dom/unregister-protocol-handler.html will be changed. So, I add platform/efl/fast/dom/unregister-protocol-handler-expected.txt in this patch. Looks good to me. Comment on attachment 146471 [details] Patch Rejecting attachment 146471 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: FAILED at 69. 1 out of 1 hunk FAILED -- saving rejects to file Source/cmake/OptionsEfl.cmake.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitperl/FeatureList.pm Hunk #1 FAILED at 169. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitperl/FeatureList.pm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13140087 Created attachment 150896 [details]
Patch
Comment on attachment 150896 [details] Patch Clearing flags on attachment: 150896 Committed r121897: <http://trac.webkit.org/changeset/121897> All reviewed patches have been landed. Closing bug. |