Bug 88592

Summary: Math.pow on iOS does not support denormal numbers.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix fpizlo: review+

Gavin Barraclough
Reported 2012-06-07 16:38:22 PDT
Import an implementation from fdlibm, detect cases where it is safe to use the system implementation & where we should fall back to fdlibm.
Attachments
fix (14.48 KB, patch)
2012-06-07 16:44 PDT, Gavin Barraclough 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-06-07 16:44:16 PDT
Created attachment 146415 [details] fix
WebKit Review Bot
Comment 2 2012-06-07 16:47:59 PDT
Attachment 146415 [details] did not pass style-queue: Source/JavaScriptCore/runtime/MathObject.cpp:226: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:230: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:361: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:362: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:363: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:365: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:366: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:367: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:368: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:373: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:396: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:398: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:398: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:398: Extra space between int and k [whitespace/declaration] [3] Source/JavaScriptCore/runtime/MathObject.cpp:399: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:400: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:401: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:401: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:402: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:402: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:402: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:403: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:403: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:403: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:404: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:405: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:406: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:406: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:407: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:407: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:408: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:409: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:409: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:409: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:411: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:411: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:412: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:413: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:413: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:413: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:415: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:416: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:416: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:417: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:417: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:417: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:419: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:420: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:426: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:426: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:426: z_h is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:426: z_l is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:426: p_h is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:426: p_l is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:427: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:427: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:428: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:428: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:429: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:429: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:430: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:430: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:432: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:432: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:432: Missing spaces around = [whitespace/operators] [4] Source/JavaScriptCore/runtime/MathObject.cpp:432: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:433: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:433: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:434: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:434: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:435: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:435: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:438: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:438: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:438: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:438: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:441: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:441: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/JavaScriptCore/runtime/MathObject.cpp:441: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:441: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:442: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:442: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:442: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:443: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:450: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:451: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:451: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:452: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:452: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:452: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:452: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:453: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:453: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:453: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:454: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:454: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:455: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:456: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:456: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:457: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:457: Missing spaces around << [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:457: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:457: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:458: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:458: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:458: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:458: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:459: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:459: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:460: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:460: Missing spaces around << [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:460: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:460: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:461: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:462: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:463: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:466: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:466: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:466: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:467: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:467: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:468: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:468: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:468: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:468: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:469: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:469: Extra space between return and y [whitespace/declaration] [3] Source/JavaScriptCore/runtime/MathObject.cpp:470: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:471: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:471: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:472: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:473: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:473: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:474: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:475: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:475: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:475: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:476: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:476: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:476: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:476: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:476: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:477: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:477: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/MathObject.cpp:478: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:478: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:478: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:478: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:479: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:479: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:479: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:480: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:480: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:481: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:482: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:483: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:485: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:487: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:487: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:487: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:488: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:488: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:488: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:488: Missing space before { [whitespace/braces] [5] Source/JavaScriptCore/runtime/MathObject.cpp:488: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:489: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:490: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:490: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:490: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:491: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:491: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:492: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:492: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:492: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:492: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:493: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:493: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:494: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:494: Missing spaces around == [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:494: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:495: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:496: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:497: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:498: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:499: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:501: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:501: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:504: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:504: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:504: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:504: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:506: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:507: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:507: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:507: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:507: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:510: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:511: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:511: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:511: Missing space before { [whitespace/braces] [5] Source/JavaScriptCore/runtime/MathObject.cpp:512: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:512: Missing spaces around <= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:512: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:513: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:513: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:513: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:514: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:515: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:516: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:516: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:516: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:516: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:517: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:517: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:517: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:520: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:521: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:522: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:523: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:524: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:525: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:526: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:527: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:528: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:528: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:528: s_l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:528: t_h is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:528: t_l is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:529: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:530: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:531: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:531: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:531: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:532: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:532: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:532: Missing space before { [whitespace/braces] [5] Source/JavaScriptCore/runtime/MathObject.cpp:533: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:533: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:534: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:535: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:536: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:536: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:537: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:537: Missing spaces around = [whitespace/operators] [4] Source/JavaScriptCore/runtime/MathObject.cpp:537: Missing spaces around <= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:537: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:537: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:538: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:538: Missing spaces around = [whitespace/operators] [4] Source/JavaScriptCore/runtime/MathObject.cpp:538: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:538: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:538: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:539: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:539: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:539: Missing spaces around = [whitespace/operators] [4] Source/JavaScriptCore/runtime/MathObject.cpp:539: Missing spaces around += [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:540: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:542: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:543: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:544: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:544: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:545: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:546: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:547: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:548: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:549: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:550: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:550: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:551: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:552: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:553: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:554: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:555: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:556: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:557: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:558: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:559: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:560: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:561: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:562: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:563: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:564: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:565: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:566: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:567: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:568: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:569: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:570: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:571: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:572: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:573: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:574: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:575: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:578: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:579: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:580: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:581: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:582: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:583: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:584: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:585: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:585: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:586: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:586: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:586: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:586: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:587: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:588: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:589: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:589: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:590: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:590: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/MathObject.cpp:591: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:591: Missing spaces around >= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:591: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:591: Extra space before ) in if [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:592: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:592: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:592: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:592: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/JavaScriptCore/runtime/MathObject.cpp:593: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:594: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:595: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:595: Missing spaces around <= [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:595: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:596: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:596: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/MathObject.cpp:597: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:601: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:602: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:602: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:603: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:604: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:605: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:605: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:606: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:606: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:607: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:608: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:608: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:609: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:609: Missing spaces around | [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:610: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:610: Missing spaces around < [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:610: Missing space before ( in if( [whitespace/parens] [5] Source/JavaScriptCore/runtime/MathObject.cpp:610: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:611: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:612: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:613: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:614: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:615: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:616: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:617: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:618: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:619: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:620: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:621: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:621: Missing spaces around / [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:622: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:623: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:624: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:624: Missing spaces around << [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:625: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:625: Missing spaces around >> [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:625: More than one command on the same line in if [whitespace/parens] [4] Source/JavaScriptCore/runtime/MathObject.cpp:625: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/runtime/MathObject.cpp:626: Tab found; better to use spaces [whitespace/tab] [1] Source/JavaScriptCore/runtime/MathObject.cpp:626: Else clause should never be on same line as else (use 2 lines) [whitespace/newline] [4] Source/JavaScriptCore/runtime/MathObject.cpp:626: Missing spaces around << [whitespace/operators] [3] Source/JavaScriptCore/runtime/MathObject.cpp:Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 626: __HI is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/MathObject.cpp:627: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 371 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2012-06-07 17:30:14 PDT
Fixed in r119775.
Csaba Osztrogonác
Comment 4 2015-02-15 00:30:47 PST
(In reply to comment #3) > Fixed in r119775. Isn't this already fixed in iOS? When can we remove this 2.5 old years old and 400 lines long workaround?
Note You need to log in before you can comment on or make changes to this bug.