Bug 88589

Summary:

[chromium] Rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bungeman, derat, epoger, reed, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Tony Chang

Reported 2012-06-07 16:25:53 PDT

[chromium] Rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction

Attachments
Patch (49.05 KB, patch) 2012-06-07 16:26 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Patch for landing (49.10 KB, patch) 2012-06-08 10:48 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2012-06-07 16:26:15 PDT

Created attachment 146411 [details] Patch

Tony Chang

Comment 2 2012-06-07 16:27:13 PDT

epoger, does this look correct to you? before: http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux/results/layout-test-results/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png after: http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux/results/layout-test-results/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-actual.png diff: http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux/results/layout-test-results/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-diff.png

Elliot Poger

Comment 3 2012-06-07 16:33:59 PDT

I really don't know. Deferring to Mike/Ben.

Mike Reed

Comment 4 2012-06-08 05:07:57 PDT

lgtm

WebKit Review Bot

Comment 5 2012-06-08 09:56:12 PDT

Comment on attachment 146411 [details] Patch Rejecting attachment 146411 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12910668

Tony Chang

Comment 6 2012-06-08 10:48:44 PDT

Created attachment 146604 [details] Patch for landing

WebKit Review Bot

Comment 7 2012-06-08 11:19:59 PDT

Comment on attachment 146604 [details] Patch for landing Clearing flags on attachment: 146604 Committed r119845: <http://trac.webkit.org/changeset/119845>

WebKit Review Bot

Comment 8 2012-06-08 11:20:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.