Bug 88570

Summary: Cache RenderLayer::isRootLayer for better performance
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jamesr, ojan, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 75001, 92258    
Attachments:
Description Flags
Proposed new caching. none

Julien Chaffraix
Reported 2012-06-07 13:13:54 PDT
The current implementation is: bool isRootLayer() const { return renderer()->isRenderView(); } Our renderer() won't change during the RenderLayer lifetime time, nor will its type. This means we could easily cache this information in the constructor. Adding this caching seems to help with painting time on http://dglazkov.github.com/performance-tests/biggrid.html.
Attachments
Proposed new caching. (8.33 KB, patch)
2012-06-07 13:40 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-06-07 13:40:39 PDT
Created attachment 146373 [details] Proposed new caching.
Ojan Vafai
Comment 2 2012-06-07 14:30:10 PDT
Comment on attachment 146373 [details] Proposed new caching. Much more readable now too!
WebKit Review Bot
Comment 3 2012-06-07 15:27:50 PDT
Comment on attachment 146373 [details] Proposed new caching. Clearing flags on attachment: 146373 Committed r119761: <http://trac.webkit.org/changeset/119761>
WebKit Review Bot
Comment 4 2012-06-07 15:27:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.