Bug 88556

Summary:

Web Inspector: optimize timeline's frame mode overview appearance for 30fps

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, keishi, loislo, nduca, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
screenshot, @60fps	none
screenshot, @18fps	none
screenshot, darker lines in front of bars, 18fps	none
screenshot, darker lines still on the bakcground, 18fps	none
screenshot, labelled pink lines in front of bars, 18fps	none
screenshot, labelled pink lines in front of bars, 60fps	none
Patch	vsevik: review+
screenshot, #333 lines on front, 18fps	none

Andrey Kosyakov

Reported 2012-06-07 11:05:32 PDT

We need a good way to see absolute frame duration in Frame mode's overview, which is in conflict with auto-scaling of bar height. Suggested fix is: - adjust scale to 30fps == full height by default; - provide a fall-back auto-scale mode when median frame is longer than 1/30s; - add horizontal lines for 30 and 60fps;

Attachments
Patch (5.61 KB, patch) 2012-06-07 11:07 PDT, Andrey Kosyakov	no flags	Details Formatted Diff Diff
screenshot, @60fps (10.10 KB, image/png) 2012-06-07 11:18 PDT, Andrey Kosyakov	no flags	Details
screenshot, @18fps (12.12 KB, image/png) 2012-06-07 11:19 PDT, Andrey Kosyakov	no flags	Details
screenshot, darker lines in front of bars, 18fps (14.12 KB, image/png) 2012-06-07 12:04 PDT, Andrey Kosyakov	no flags	Details
screenshot, darker lines still on the bakcground, 18fps (9.33 KB, image/png) 2012-06-07 12:05 PDT, Andrey Kosyakov	no flags	Details
screenshot, labelled pink lines in front of bars, 18fps (12.34 KB, image/png) 2012-06-08 07:43 PDT, Andrey Kosyakov	no flags	Details
screenshot, labelled pink lines in front of bars, 60fps (9.02 KB, image/png) 2012-06-08 07:44 PDT, Andrey Kosyakov	no flags	Details
Patch (6.99 KB, patch) 2012-06-08 07:56 PDT, Andrey Kosyakov	vsevik: review+	Details Formatted Diff Diff
screenshot, #333 lines on front, 18fps (5.41 KB, image/png) 2012-06-08 09:13 PDT, Andrey Kosyakov	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2012-06-07 11:07:47 PDT

Created attachment 146328 [details] Patch

Andrey Kosyakov

Comment 2 2012-06-07 11:18:41 PDT

Created attachment 146334 [details] screenshot, @60fps

Andrey Kosyakov

Comment 3 2012-06-07 11:19:24 PDT

Created attachment 146336 [details] screenshot, @18fps

Andrey Kosyakov

Comment 4 2012-06-07 12:04:31 PDT

Created attachment 146352 [details] screenshot, darker lines in front of bars, 18fps

Andrey Kosyakov

Comment 5 2012-06-07 12:05:08 PDT

Created attachment 146354 [details] screenshot, darker lines still on the bakcground, 18fps

Andrey Kosyakov

Comment 6 2012-06-08 07:43:32 PDT

Created attachment 146567 [details] screenshot, labelled pink lines in front of bars, 18fps

Andrey Kosyakov

Comment 7 2012-06-08 07:44:29 PDT

Created attachment 146568 [details] screenshot, labelled pink lines in front of bars, 60fps

Andrey Kosyakov

Comment 8 2012-06-08 07:56:50 PDT

Created attachment 146572 [details] Patch

Andrey Kosyakov

Comment 9 2012-06-08 09:13:38 PDT

Created attachment 146582 [details] screenshot, #333 lines on front, 18fps Here's one with dark lines (a bit too contrast to my taste) No dashes so far, as it turns out WebKit's canvas only supports that via image-based patterns.

Andrey Kosyakov

Comment 10 2012-06-09 03:15:11 PDT

Committed r119896: <http://trac.webkit.org/changeset/119896>

Note You need to log in before you can comment on or make changes to this bug.