Bug 88516 – REGRESSION(r119689): it broke didDrawNotCalledOnScissoredLayer webkit_unit_test (Requested by loislo on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/119689 broke the build:
it broke didDrawNotCalledOnScissoredLayer webkit_unit_test (Requested by loislo on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 146237 [details]
ROLLOUT of r119689

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Ilya Tikhonovsky]

Comment on attachment 146237 [details]
ROLLOUT of r119689

Clearing flags on attachment: 146237

Committed r119696: <http://trac.webkit.org/changeset/119696>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.

[Ilya Tikhonovsky]

It happened on Mac dbg.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/7966

the log: 

[ RUN      ] CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer
ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
../../WTF/wtf/HashTable.h(498) : void WTF::HashTable<int, std::pair<int, WebCore::FloatRect>, WTF::PairFirstExtractor<std::pair<int, WebCore::FloatRect> >, WTF::IntHash<unsigned int>, WTF::HashMapValueTraits<WTF::HashTraits<int>, WTF::HashTraits<WebCore::FloatRect> >, WTF::HashTraits<int> >::checkKey(const T &) [Key = int, Value = std::pair<int, WebCore::FloatRect>, Extractor = WTF::PairFirstExtractor<std::pair<int, WebCore::FloatRect> >, HashFunctions = WTF::IntHash<unsigned int>, Traits = WTF::HashMapValueTraits<WTF::HashTraits<int>, WTF::HashTraits<WebCore::FloatRect> >, KeyTraits = WTF::HashTraits<int>, HashTranslator = WTF::HashMapTranslator<WTF::HashMapValueTraits<WTF::HashTraits<int>, WTF::HashTraits<WebCore::FloatRect> >, WTF::IntHash<unsigned int> >, T = int]
1   0x3a19c629 start
2   0x3a19c156 start
3   0x3a19c00f start
4   0x3a19a376 start
5   0x3a199232 start
6   0x3a199903 start
7   0x3a198d13 start
8   0x3a198ae8 start
9   0x3a1eca49 start
10  0x3a1ecf74 start
11  0x3a1ed222 start
12  0x3a1ee07b start
13  0x377fa6c8 start
14  0x38104291 start
15  0x380f98ce start
16  0x380ee90e start
17  0x380eef67 start
18  0x380ef4e9 start
19  0x380f4815 start
20  0x38101f31 start
21  0x380fba7e start
22  0x380f44a4 start
23  0x382adcc0 start
24  0x376637c9 start
25  0x37663726 start
[1034:-1603913952:0607/004303:217531715938:ERROR:process_util_posix.cc(143)] Received signal 11
	0   webkit_unit_tests                   0x3815bfff start + 11503887
	1   webkit_unit_tests                   0x3815bf9b start + 11503787
	2   webkit_unit_tests                   0x382164e7 start + 12266999
	3   libSystem.B.dylib                   0x94e551cb _sigtramp + 43
	4   ???                                 0xffffffff 0x0 + 4294967295
	5   webkit_unit_tests                   0x3a19c156 start + 45320806
	6   webkit_unit_tests                   0x3a19c00f start + 45320479
	7   webkit_unit_tests                   0x3a19a376 start + 45313158
	8   webkit_unit_tests                   0x3a199232 start + 45308738
	9   webkit_unit_tests                   0x3a199903 start + 45310483
	10  webkit_unit_tests                   0x3a198d13 start + 45307427
	11  webkit_unit_tests                   0x3a198ae8 start + 45306872
	12  webkit_unit_tests                   0x3a1eca49 start + 45650777
	13  webkit_unit_tests                   0x3a1ecf74 start + 45652100
	14  webkit_unit_tests                   0x3a1ed222 start + 45652786
	15  webkit_unit_tests                   0x3a1ee07b start + 45656459
	16  webkit_unit_tests                   0x377fa6c8 start + 1667032
	17  webkit_unit_tests                   0x38104291 start + 11144097
	18  webkit_unit_tests                   0x380f98ce start + 11100638
	19  webkit_unit_tests                   0x380ee90e start + 11055646
	20  webkit_unit_tests                   0x380eef67 start + 11057271
	21  webkit_unit_tests                   0x380ef4e9 start + 11058681
	22  webkit_unit_tests                   0x380f4815 start + 11079973
	23  webkit_unit_tests                   0x38101f31 start + 11135041
	24  webkit_unit_tests                   0x380fba7e start + 11109262
	25  webkit_unit_tests                   0x380f44a4 start + 11079092
	26  webkit_unit_tests                   0x382adcc0 start + 12887504
	27  webkit_unit_tests                   0x376637c9 start + 217
	28  webkit_unit_tests                   0x37663726 start + 54
ax: bbadbeef, bx: 42b5eccb, cx: 42b5eccb, dx: 42b5eccb
di: 3c025c60, si: 3c285a09, bp: bfffe258, sp: bfffe200, ss: 1f, flags: 10282
ip: 3a19c633, cs: 17, ds: 1f, es: 1f, fs: 0, gs: 37
program finished with exit code 1
elapsedTime=0.717877

[Dana Jansens]

Oh my, okay thanks for the report.