Bug 8851

Summary: REGRESSION: RTL text shifted to the right
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt
Priority: P1 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch
none
Add length to the TextRun constructor hyatt: review+

mitz
Reported 2006-05-11 09:28:56 PDT
In fast/text/in-rendered-text-rtl.html, the space after the first two words is too big (that test fails for a different reason).
Attachments
Patch (626 bytes, patch)
2006-05-11 09:29 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Add length to the TextRun constructor (9.49 KB, patch)
2006-05-11 16:06 PDT, mitz 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-05-11 09:29:51 PDT
Created attachment 8240 [details] Patch
mitz
Comment 2 2006-05-11 09:44:30 PDT
Comment on attachment 8240 [details] Patch This made things even worse for highlighting and hit testing.
mitz
Comment 3 2006-05-11 12:25:19 PDT
You can't infer the TextRun's length from the StringImpl's length (and the offset). I think I'll add an optional length parameter to the TextRun constructor.
mitz
Comment 4 2006-05-11 16:06:48 PDT
Created attachment 8254 [details] Add length to the TextRun constructor
Dave Hyatt
Comment 5 2006-05-11 16:18:51 PDT
Comment on attachment 8254 [details] Add length to the TextRun constructor r=me
Dave Hyatt
Comment 6 2006-05-11 16:20:21 PDT
Fixed
Note You need to log in before you can comment on or make changes to this bug.