Bug 88480

Summary: [Platform] Introduce conversion from/to Deciaml to/from double
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88383    
Attachments:
Description Flags
Build verification
none
Patch 2 none

yosin
Reported 2012-06-06 18:42:25 PDT
To reduce size of patch of bug 88383, we introduce following functions: * Decimal Decimal::fromDouble(double) -- this is implementation of convertDoubleToInputNumber * double Decimal::toDouble() const -- this is implementation of convertInputNumberToDouble * bool isfinite(const Decimal&) * bool isinf(const Decimal&) * bool isnan(const Decimal&)
Attachments
Build verification (12.70 KB, patch)
2012-06-06 19:33 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (11.34 KB, patch)
2012-06-06 20:39 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-06 19:33:21 PDT
Created attachment 146179 [details] Build verification
Build Bot
Comment 2 2012-06-06 19:39:46 PDT
Comment on attachment 146179 [details] Build verification Attachment 146179 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12919024
yosin
Comment 3 2012-06-06 20:22:58 PDT
Since some platforms define isfinite/isinf/isnan as macro. We can't define overload version for them. :<
yosin
Comment 4 2012-06-06 20:39:58 PDT
Created attachment 146183 [details] Patch 2
yosin
Comment 5 2012-06-06 21:09:54 PDT
Comment on attachment 146183 [details] Patch 2 Could you review this patch? Thanks in advance. * It seems win-ews is stuck.
Kent Tamura
Comment 6 2012-06-06 21:21:11 PDT
Comment on attachment 146183 [details] Patch 2 ok
WebKit Review Bot
Comment 7 2012-06-07 00:57:15 PDT
Comment on attachment 146183 [details] Patch 2 Clearing flags on attachment: 146183 Committed r119692: <http://trac.webkit.org/changeset/119692>
WebKit Review Bot
Comment 8 2012-06-07 00:57:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.