| Summary: | Debug build fails with recent clang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nuno Lopes <nlopes> | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | andersca, cmarcelo, macpherson, menard, ossy, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Just a quick explanation why this patch is necessary: Node::hasTagName() is defined in Element.h, which is included by Element.cpp. However, since this method is declared 'inline', newer versions of clang remove the symbol from Element.o, which is required by CSSStyleSheet.o when built in debug mode. Including the Element.h fixes the problem, since then the method is available directly to CSSStyleSheet.cpp. Comment on attachment 146113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146113&action=review Looks reasonable but please fix the change log. Also please explain why you need to include Element.h here. > Source/WebCore/ChangeLog:4 > + You're missing bug URL. Comment on attachment 146113 [details]
Patch
Please fix the change log entry before you land it.
I don't think if it is still valid after 3 years. |
Created attachment 146113 [details] Patch Debug build fails with recent clang.