Bug 88457

Summary:

Debug build fails with recent clang

Product:

WebKit

Reporter:

Nuno Lopes <nlopes>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

andersca, cmarcelo, macpherson, menard, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+, rniwa: commit-queue-

Nuno Lopes

Reported 2012-06-06 14:41:17 PDT

Created attachment 146113 [details] Patch Debug build fails with recent clang.

Attachments
Patch (960 bytes, patch) 2012-06-06 14:41 PDT, Nuno Lopes	rniwa: review+ rniwa: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nuno Lopes

Comment 1 2012-06-18 09:14:42 PDT

Just a quick explanation why this patch is necessary: Node::hasTagName() is defined in Element.h, which is included by Element.cpp. However, since this method is declared 'inline', newer versions of clang remove the symbol from Element.o, which is required by CSSStyleSheet.o when built in debug mode. Including the Element.h fixes the problem, since then the method is available directly to CSSStyleSheet.cpp.

Ryosuke Niwa

Comment 2 2012-07-19 16:30:47 PDT

Comment on attachment 146113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146113&action=review Looks reasonable but please fix the change log. Also please explain why you need to include Element.h here. > Source/WebCore/ChangeLog:4 > + You're missing bug URL.

Ryosuke Niwa

Comment 3 2012-08-08 00:10:56 PDT

Comment on attachment 146113 [details] Patch Please fix the change log entry before you land it.

Csaba Osztrogonác

Comment 4 2015-06-24 07:14:05 PDT

I don't think if it is still valid after 3 years.

Note You need to log in before you can comment on or make changes to this bug.