Bug 88389

Summary: FileAPI: Remove deprecation warning when ArrayBuffer is in Blob constructor.
Product: WebKit Reporter: Li Yin <li.yin>
Component: WebCore Misc.Assignee: Li Yin <li.yin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, buildbot, eoconnor, haraken, jianli, kbr, kinuko, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 88294, 90534    
Bug Blocks:    
Attachments:
Description Flags
Patch kbr: review+, buildbot: commit-queue-

Li Yin
Reported 2012-06-05 19:33:23 PDT
From Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters. This bug depends on Bug 88294
Attachments
Patch (5.93 KB, patch)
2013-03-21 06:29 PDT, Li Yin 		kbr: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Li Yin
Comment 1 2013-03-21 05:52:44 PDT
Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob Both ArrayBuffer and ArrayBufferView should be supported for Constructor Parameters. So we need to remove the deprecated warning for ArrayBuffer.
Li Yin
Comment 2 2013-03-21 06:29:02 PDT
Created attachment 194244 [details] Patch
Build Bot
Comment 3 2013-03-21 07:05:41 PDT
Comment on attachment 194244 [details] Patch Attachment 194244 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17193561
Build Bot
Comment 4 2013-03-21 11:23:34 PDT
Comment on attachment 194244 [details] Patch Attachment 194244 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17288124
Kenneth Russell
Comment 5 2013-03-21 11:32:28 PDT
Comment on attachment 194244 [details] Patch Looks fine, but the unused parameter build failure needs to be fixed.
Li Yin
Comment 6 2013-03-21 20:14:16 PDT
Committed r146557: <http://trac.webkit.org/changeset/146557>
Note You need to log in before you can comment on or make changes to this bug.