Summary: | Remove JSObject::m_inheritorID | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, fpizlo, mhahnenberg, mitz, ossy, zarvai | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 92338 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Gavin Barraclough
2012-06-05 17:12:51 PDT
Created attachment 145900 [details]
Fix
Comment on attachment 145900 [details]
Fix
r=me
(In reply to comment #3) > Fixed in r119556 This broke the 32-bit build, as far as I can tell because it made the m_inlineStorage data member in JSNonFinalObject not 4-byte aligned, causing the assertion in finishCreation() to fail. I didn’t know how to fix the build, so I reverted this change in <http://trac.webkit.org/r119568>. Comment on attachment 145900 [details]
Fix
Changing to r- because it breaks the 32-bit build.
(In reply to comment #7) > Re-landed in r119795 Layout test fails on Qt, GTK, EFL and Lion after r119795: jquery/core.html Ugh. I'll revert in the morning if no-one else has done so, & debug. cheers for reporting this. Rolled back out in 119865. :'-( Created attachment 154496 [details]
Patch
Committed r123682: <http://trac.webkit.org/changeset/123682> (In reply to comment #12) > Committed r123682: <http://trac.webkit.org/changeset/123682> It made many tests crash on 32 bit platforms. Could you check it, please? new bug report for this regression - https://bugs.webkit.org/show_bug.cgi?id=92338 Fixed by http://trac.webkit.org/changeset/123708. Thanks. |