Bug 88362

Summary: DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch barraclough: review+

Filip Pizlo
Reported 2012-06-05 13:48:04 PDT
This is not only dangerous (you might go down an infinite deref recursion if you hit a dead cycle) but entirely unnecessary (the subgraph is going to get deleted anyway regardless of ref counts).
Attachments
the patch (2.19 KB, patch)
2012-06-05 13:53 PDT, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-06-05 13:53:40 PDT
Created attachment 145865 [details] the patch Still trying to figure out the best way to test this.
Filip Pizlo
Comment 2 2012-06-05 14:32:45 PDT
Landed in http://trac.webkit.org/changeset/119526
Filip Pizlo
Comment 3 2012-06-05 14:40:38 PDT
*** Bug 87994 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.