Bug 88352

Summary: Web Inspector: help/settings screen does not overlay console in split screen mode
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: eustas.bug
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, eustas.bug, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andrey Kosyakov 2012-06-05 11:29:49 PDT 
1. Open Web Inspector
2. Switch to any panel other than Console
3. Press Esc to enable split-screen mode with console at the bottom
4. Press Settings cog in the bottom right corner
5. Reduce height of inspector window if necessary

Help/Settings screen used to float on top of the console. Now it fits the upper panel.
Comment 1 eustas.bug 2012-06-05 23:35:17 PDT 
Created attachment 145943 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-05 23:38:19 PDT 
Attachment 145943 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andrey Kosyakov 2012-06-06 01:27:47 PDT 
Comment on attachment 145943 [details]
Patch

LGTM
Comment 4 Pavel Feldman 2012-06-06 01:52:30 PDT 
Comment on attachment 145943 [details]
Patch

Please fix the ChangeLog prior to landing.
Comment 5 eustas.bug 2012-06-06 03:36:20 PDT 
Created attachment 145982 [details]
Patch
Comment 6 Andrey Kosyakov 2012-06-06 03:42:18 PDT 
Committed r119581: <http://trac.webkit.org/changeset/119581>
Comment 7 Vsevolod Vlasov 2012-06-06 03:48:13 PDT 
Comment on attachment 145982 [details]
Patch

Clearing r?