Bug 8835

Summary: REGRESSION: Line moves but selection highlight stays behind
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Regression
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Adjust m_selectionTop and m_selectionBottom darin: review+

mitz
Reported 2006-05-10 11:22:50 PDT
When a root line box moves vertically during relayout, its vertical selection bounds aren't updated, so the selection highlight is painted in the old position. This is a regression from the fix for bug 7301. The patch I'm going to attach includes a test case.
Attachments
Adjust m_selectionTop and m_selectionBottom (6.04 KB, patch)
2006-05-10 11:35 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-05-10 11:35:28 PDT
Created attachment 8223 [details] Adjust m_selectionTop and m_selectionBottom
Darin Adler
Comment 2 2006-05-10 11:41:19 PDT
Comment on attachment 8223 [details] Adjust m_selectionTop and m_selectionBottom r=me
Darin Adler
Comment 3 2006-05-12 20:19:32 PDT
Committed revision 14347.
mitz
Comment 4 2006-05-13 01:13:42 PDT
Not fixed. I'm not sure why render_line.cpp is still around, but the code this patch should modify is now in RootInlineBox.cpp.
Alexey Proskuryakov
Comment 5 2006-05-13 08:25:27 PDT
Applied to RootInlineBox.cpp, removed render_line.cpp - r14354
Note You need to log in before you can comment on or make changes to this bug.