Bug 88295

Summary: [EFL][WK2] WebKit2-EFL does not link with gold linker
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2012-06-04 23:26:45 PDT
WebKit2-EFL does not link with gold linker:

Linking CXX executable ../../bin/WebProcess
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'soup_cookie_jar_get_accept_policy'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_type_init'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_getenv'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'soup_session_add_feature_by_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_ptr_array_new_with_free_func'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_ptr_array_add'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'soup_session_feature_remove_feature'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_type_class_ref'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'soup_session_feature_add_feature'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_ptr_array_remove_index_fast'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_input_stream_get_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_get_op_res_gpointer'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_object_ref'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_async_result_get_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_async_result_get_source_object'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_memdup'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_memory_input_stream_new_from_data'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_set_op_res_gpointer'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'soup_request_get_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_quark_from_string'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_set_error'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_complete'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_get_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_get_source_tag'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_warn_message'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_propagate_error'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_new'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_get_op_res_gssize'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_memory_input_stream_get_type'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_take_error'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_complete_in_idle'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_simple_async_result_set_op_res_gssize'
../../lib/libewebkit2.so.0.1.0: error: undefined reference to 'g_memory_input_stream_add_data'

Some LDFLAGS are certainly missing.
Comment 1 Chris Dumez 2012-06-04 23:29:38 PDT
Created attachment 145700 [details]
Patch
Comment 2 Ryuan Choi 2012-06-04 23:42:33 PDT
(In reply to comment #1)
> Created an attachment (id=145700) [details]
> Patch

Good to me.
However, I think that you can land this as Unreviewed build fix.
Comment 3 Chris Dumez 2012-06-04 23:54:14 PDT
Created attachment 145704 [details]
Patch

Fine by me. Could you please cq+ ?
Comment 4 Ryuan Choi 2012-06-04 23:57:27 PDT
Comment on attachment 145704 [details]
Patch

Thank you for fixing.
Comment 5 WebKit Review Bot 2012-06-05 04:13:30 PDT
Comment on attachment 145704 [details]
Patch

Clearing flags on attachment: 145704

Committed r119480: <http://trac.webkit.org/changeset/119480>
Comment 6 WebKit Review Bot 2012-06-05 04:13:35 PDT
All reviewed patches have been landed.  Closing bug.