Summary: | [EFL] Implement to support layout test of notifications. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kihong Kwon <kihong.kwon> | ||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | cdumez, donggwan.kim, gyuyoung.kim, jinwoo7.song, lucas.de.marchi, mcatanzaro, rakuco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Bug Depends on: | 73544 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Kihong Kwon
2012-06-04 22:42:37 PDT
Created attachment 145760 [details] Patch. There are needed to land bug #73544 for building this. Comment on attachment 145760 [details]
Patch.
We usually dump information on DRT side, not on WebKit side. Why are you doing it differently?
Comment on attachment 145760 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=145760&action=review > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:68 > + printf("DESKTOP NOTIFICATION: contents at %s\n", notification->url().string().utf8().data()); As above comment, we have print console message in DRT side. Please move this to DRT side. > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:52 > + static bool dumpNotification; We don't need to use this flag if you move console message to DRT side. Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. |