Bug 88291

Summary: [EFL] Implement to support layout test of notifications.
Product: WebKit Reporter: Kihong Kwon <kihong.kwon>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: cdumez, donggwan.kim, gyuyoung.kim, jinwoo7.song, lucas.de.marchi, mcatanzaro, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 73544    
Bug Blocks:    
Description Flags
Patch. gyuyoung.kim: review-

Description Kihong Kwon 2012-06-04 22:42:37 PDT
These are implementation to support layout test on the EFL.
Comment 1 Kihong Kwon 2012-06-05 04:55:26 PDT
Created attachment 145760 [details]

There are needed to land bug #73544 for building this.
Comment 2 Chris Dumez 2012-09-04 23:05:22 PDT
Comment on attachment 145760 [details]

We usually dump information on DRT side, not on WebKit side. Why are you doing it differently?
Comment 3 Gyuyoung Kim 2012-09-04 23:26:02 PDT
Comment on attachment 145760 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=145760&action=review

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:68
> +            printf("DESKTOP NOTIFICATION: contents at %s\n", notification->url().string().utf8().data());

As above comment, we have print console message in DRT side. Please move this to DRT side.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:52
> +    static bool dumpNotification;

We don't need to use this flag if you move console message to DRT side.
Comment 4 Michael Catanzaro 2017-03-11 10:36:33 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.