Bug 88286

Summary:

Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel

Product:

WebKit

Reporter:

Rahul Tiwari <rahultiwari.cse.iitr>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, vivekgalatage, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+, webkit.review.bot: commit-queue-

Rahul Tiwari

Reported 2012-06-04 20:52:25 PDT

On Profiles Panel, currently we can use "DELETE" button from keyboard to delete the selected profile. But it would be nice to have a context menu as well to do the job.

Attachments
Patch (58.49 KB, patch) 2012-06-05 06:51 PDT, Rahul Tiwari	no flags	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2012-06-12 06:00 PDT, Rahul Tiwari	pfeldman: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Rahul Tiwari

Comment 1 2012-06-04 20:52:56 PDT

Patch to follow.

Rahul Tiwari

Comment 2 2012-06-05 06:51:30 PDT

Created attachment 145781 [details] Patch

Pavel Feldman

Comment 3 2012-06-05 07:18:34 PDT

Comment on attachment 145781 [details] Patch LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good.

Rahul Tiwari

Comment 4 2012-06-05 21:00:43 PDT

I checked the file type and it shows as utf 8 only with the svn mime-type as application octet stream. (In reply to comment #3) > (From update of attachment 145781 [details]) > LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good.

Rahul Tiwari

Comment 5 2012-06-06 21:24:30 PDT

(In reply to comment #3) > (From update of attachment 145781 [details]) > LocalizedStrings is now UTF8 (not binary). Please edit it as text and convert to UTF8 if necessary. Otherwise looks good. Thank you Pavel. I issued the following command to check the encoding of the file and got file -bi localizedStrings.js => text/plain; charset=utf-8 But when I check the svn property on this file with svn propget svn:mime-type localizedStrings.js => application/octet-stream So is this the issue that you have pointed out? I apologize but I am little confused with these outputs and your comments. Please suggest.

Rahul Tiwari

Comment 6 2012-06-08 05:20:55 PDT

Pavel, do you have any suggestions?

Rahul Tiwari

Comment 7 2012-06-12 06:00:46 PDT

Created attachment 147066 [details] Patch

WebKit Review Bot

Comment 8 2012-06-12 06:21:28 PDT

Comment on attachment 147066 [details] Patch Rejecting attachment 147066 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 9 cwd: /mnt/git/webkit-commit-queue/ Failed to find the property value for the SVN property "svn:mime-type": "## -1 +0,0 ## ". at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1199, <ARGV> line 36. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 9 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12948454

Pavel Feldman

Comment 9 2012-06-12 06:58:33 PDT

Committed r120070: <http://trac.webkit.org/changeset/120070>

Note You need to log in before you can comment on or make changes to this bug.