Bug 88247

Summary: [Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, menard, vestbo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dinu Jacob
Reported 2012-06-04 12:34:23 PDT
With 855a3ec2, there is no need for the Timer hack in single file upload and multi-file upload API tests.
Attachments
Patch (3.09 KB, patch)
2012-06-04 12:48 PDT, Dinu Jacob 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2012-06-05 11:49 PDT, Dinu Jacob 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dinu Jacob
Comment 1 2012-06-04 12:48:45 PDT
Created attachment 145618 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2012-06-05 11:42:39 PDT
Comment on attachment 145618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review > Source/WebKit2/ChangeLog:8 > + With commit 855a3ec2, Component.onCompleted can be used for callback instead of the To which repository does this commit refer?
Dinu Jacob
Comment 3 2012-06-05 11:45:10 PDT
(In reply to comment #2) > (From update of attachment 145618 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=145618&action=review > > > Source/WebKit2/ChangeLog:8 > > + With commit 855a3ec2, Component.onCompleted can be used for callback instead of the > > To which repository does this commit refer? ah, the git repository. I guess I should use the revision number instead!
Dinu Jacob
Comment 4 2012-06-05 11:49:35 PDT
Created attachment 145849 [details] Patch Updated the ChangeLog to use the revision number instead of the git commit id.
WebKit Review Bot
Comment 5 2012-06-05 22:32:43 PDT
Comment on attachment 145849 [details] Patch Clearing flags on attachment: 145849 Committed r119559: <http://trac.webkit.org/changeset/119559>
WebKit Review Bot
Comment 6 2012-06-05 22:32:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.