Bug 88223 – [Qt] Fix -Werror for the buildbots

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Csaba Osztrogonác]

After http://trac.webkit.org/changeset/119269 
none of our buildbot uses -Werror. :-/

The problem is that qt_developer_build doesn't exist for Qt 4.8 build at all,
and our build script doesn't use -developer-build for Qt 5 builds:
https://github.com/ossy-szeged/qt5-tools (Because nobody asked we should use it.)

I tried to build a new Qt5 with -developer-build option and then build Webkit with it,
but unfortunately the WebKit build faild with the following error message:
cp: cannot create regular file `/usr/local/Trolltech/Qt5/Qt-5.0.0-r33/mkspecs/modules/qt_webkit.pri': Permission denied

I have no idea why WebKit build wants copy anything into Qt install directory,
but it isn't a good idea to let build-webkit write anything into Qt install dir.

Any idea how can we enable Werror on the bots again?
What if we enable -Werror for 4.8 builds until proper fix?

[Csaba Osztrogonác]

Of course we can add an environment to the bots: (buildbots and EWS)
export BUILD_WEBKIT_ARGS="QMAKE_CXXFLAGS+=-Werror"

But it won't force developers to use Werror ...

[Csaba Osztrogonác]

Balázs ran into this problem, because somebody broke the Werror build, but we don't have Werror EWS and buildbots ...

[Csaba Osztrogonác]

discussion about it:

<kbalazs> torarne: couldn't we autodetect custom toochains?
<torarne> right, we should probably remove that qt_developer_build check
<torarne> it's too limiting. webkit should probably always be in "developer mode", regardless of how qt was built
<torarne> and in some cases it will be in "production" mode, eg when building as part of qt5.git with a non-dev-mode qt
<torarne> Ossy: rs=me on reverting this part for now http://trac.webkit.org/changeset/119269/trunk/Tools/qmake/mkspecs/features/unix/default_post.prf
<Ossy> torarne, or what if we remove this developer checking and we add after importing WebKit as Qt5 module?
<torarne> Ossy: yes. well, we should keep the code the same, and have a flag or CONFIG+=production, but in practice the qt-import will behave slightly differently

enable Werror again landed in http://trac.webkit.org/changeset/120083

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.